Improve file picker guidance for iCloud Drive and Other File Provider

Author: tobihagemann

Cryptomator/AddVault/CreateNewVault/LocalVault/CreateNewLocalVaultViewModel.swift

@@ -16,7 +16,13 @@ class CreateNewLocalVaultViewModel: LocalFileSystemAuthenticationViewModel, Loca
 
 	init(vaultName: String, selectedLocalFileSystemType: LocalFileSystemType, accountManager: CloudProviderAccountManager = CloudProviderAccountDBManager.shared) {
 		let documentPickerButtonText = LocalizedString.getValue("localFileSystemAuthentication.createNewVault.button")
-		let headerText = LocalizedString.getValue("localFileSystemAuthentication.createNewVault.header")
+		let headerText: String
+		switch selectedLocalFileSystemType {
+		case .iCloudDrive:
+			headerText = LocalizedString.getValue("localFileSystemAuthentication.createNewVault.iCloudDrive.header")
+		case .custom:
+			headerText = LocalizedString.getValue("localFileSystemAuthentication.createNewVault.otherFileProvider.header")
+		}
 		self.vaultName = vaultName
 		super.init(documentPickerButtonText: documentPickerButtonText, headerText: headerText, selectedLocalFileSystemType: selectedLocalFileSystemType, validationLogic: CreateNewLocalVaultValidationLogic(vaultName: vaultName), accountManager: accountManager)
 	}

Cryptomator/AddVault/OpenExistingVault/LocalVault/OpenExistingLocalVaultViewModel.swift

@@ -15,7 +15,13 @@ class OpenExistingLocalVaultViewModel: LocalFileSystemAuthenticationViewModel, L
 	private let validator: OpenExistingLocalVaultValidationLogic
 	init(selectedLocalFileSystemType: LocalFileSystemType, accountManager: CloudProviderAccountManager = CloudProviderAccountDBManager.shared) {
 		let documentPickerButtonText = LocalizedString.getValue("localFileSystemAuthentication.openExistingVault.button")
-		let headerText = LocalizedString.getValue("localFileSystemAuthentication.openExistingVault.header")
+		let headerText: String
+		switch selectedLocalFileSystemType {
+		case .iCloudDrive:
+			headerText = LocalizedString.getValue("localFileSystemAuthentication.openExistingVault.iCloudDrive.header")
+		case .custom:
+			headerText = LocalizedString.getValue("localFileSystemAuthentication.openExistingVault.otherFileProvider.header")
+		}
 		self.validator = OpenExistingLocalVaultValidationLogic()
 		super.init(documentPickerButtonText: documentPickerButtonText, headerText: headerText, selectedLocalFileSystemType: selectedLocalFileSystemType, validationLogic: validator, accountManager: accountManager)
 	}

SharedResources/en.lproj/Localizable.strings

@@ -145,10 +145,12 @@
 "keepUnlockedDuration.auto.shortDisplayName" = "Auto";
 "keepUnlockedDuration.indefinite" = "Indefinite";
 
-"localFileSystemAuthentication.createNewVault.header" = "In the next screen, choose the storage location for your new vault.";
+"localFileSystemAuthentication.createNewVault.iCloudDrive.header" = "In the next screen, navigate to iCloud Drive, select a storage location, then tap Open.";
+"localFileSystemAuthentication.createNewVault.otherFileProvider.header" = "In the next screen, navigate to your storage location, select it, then tap Open.";
 "localFileSystemAuthentication.createNewVault.button" = "Select Storage Location";
 "localFileSystemAuthentication.createNewVault.error.detectedExistingVault" = "A vault already exists at this location. Please try again with a different storage location.";
-"localFileSystemAuthentication.openExistingVault.header" = "In the next screen, choose the folder of your existing vault.";
+"localFileSystemAuthentication.openExistingVault.iCloudDrive.header" = "In the next screen, navigate to iCloud Drive, select your vault folder, then tap Open.";
+"localFileSystemAuthentication.openExistingVault.otherFileProvider.header" = "In the next screen, navigate to your vault folder, select it, then tap Open.";
 "localFileSystemAuthentication.openExistingVault.button" = "Select Vault Folder";
 "localFileSystemAuthentication.openExistingVault.error.noVaultFound" = "The selected folder is not a vault. Please try again with a different folder.";
 "localFileSystemAuthentication.info.footer" = "File providers that are grayed out don't support \"picking folders\". This is not a limitation of Cryptomator.";