log/views: render external types via generic blueprint fallback#338
Closed
Rekseto wants to merge 1 commit into
Closed
log/views: render external types via generic blueprint fallback#338Rekseto wants to merge 1 commit into
Rekseto wants to merge 1 commit into
Conversation
Objects of external types (blueprint-backed astral.RuntimeObject) had no
compiled-in view, so fmt.ViewFor fell through to %v and printed the raw Go
carrier (pointer hex, internal field/index state) instead of a readable value.
Add a fallback hook to the view lookup: fmt.SetFallbackView installs a builder
consulted on a per-type registry miss, before the Stringify path. mod/log/views
registers RuntimeObjectView there, rendering Type{Field: value, ...} for struct
kind and Type(value) for alias kind, delegating each field to fmt.ViewFor so
nested primitives and nested external types render through the same machinery.
Runtime container carriers (RuntimeSlice/RuntimeArray/RuntimeMap) expose a
constant ObjectType, so they register per-type via fmt.SetView; the map view
sorts keys for deterministic log output. A new RuntimeObject.Blueprint()
accessor exposes the schema the view iterates.
Fixes #337.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Finished by our @astral-intern0 963fefc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects of external types (blueprint-backed astral.RuntimeObject) had no compiled-in view, so fmt.ViewFor fell through to %v and printed the raw Go carrier (pointer hex, internal field/index state) instead of a readable value.
Add a fallback hook to the view lookup: fmt.SetFallbackView installs a builder consulted on a per-type registry miss, before the Stringify path. mod/log/views registers RuntimeObjectView there, rendering Type{Field: value, ...} for struct kind and Type(value) for alias kind, delegating each field to fmt.ViewFor so nested primitives and nested external types render through the same machinery.
Runtime container carriers (RuntimeSlice/RuntimeArray/RuntimeMap) expose a constant ObjectType, so they register per-type via fmt.SetView; the map view sorts keys for deterministic log output. A new RuntimeObject.Blueprint() accessor exposes the schema the view iterates.
Fixes #337.