removes FN-DSA (Falcon)#19
Merged
cryptoquick merged 3 commits intocryptoquick:mainfrom Jun 27, 2025
Merged
Conversation
Removed a comment.
Closed
cryptoquick
requested changes
Jun 20, 2025
Comment on lines
192
to
199
| /// Creates an Algorithm variant infallibly from an index 0..2. | ||
| /// Maps 0 -> SECP256K1_SCHNORR (1), 1 -> ML_DSA_44 (2), 2 -> SLH_DSA_128S (4) | ||
| /// TODO: ensure this is correct mapping with FN_DSA out! | ||
| pub fn algorithm_from_index(index: u8) -> Algorithm { | ||
| let valid_index = index % 4; // Ensure value is within 0..3 | ||
| let bits = 1u8 << valid_index; // Map 0->1, 1->2, 2->4, 3->8 | ||
| let valid_index = index % 4; // Ensure value is within 0..2 | ||
| let bits = 1u8 << valid_index; // Map 0->1, 1->2, 2->4, 3->8 ... | ||
| Algorithm::from(bits) | ||
| } |
cryptoquick
requested changes
Jun 26, 2025
Comment on lines
+12
to
+13
| | ML-DSA-44 | *Needs Update* | *Needs Update* | *Needs Update* | | ||
| | SLH-DSA-128S | *Needs Update* | *Needs Update* | *Needs Update* | |
Owner
There was a problem hiding this comment.
Also, this is weird... I think we may have lost some benchmark code somewhere
Collaborator
Author
There was a problem hiding this comment.
Yeah, I noticed this as well. Had a look into it and this is what the benchmark report returns with. Looks like some previous change in the cargo bench workflow, but unrelated to the changes in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes remove FN-DSA implementation, tests, and documentation.