hlint: apply some lint suggestions

Author: elopez

lib/Echidna/ABI.hs

@@ -191,7 +191,7 @@ getRandomInt :: MonadRandom m => Int -> m Integer
 getRandomInt n =
   getRandomR =<< Random.weighted
     [ ((-1023, 1023), 1)
-    , ((-1 * 2 ^ (n - 1), 2 ^ (n - 1) - 1), 9)
+    , (((-1) * 2 ^ (n - 1), 2 ^ (n - 1) - 1), 9)
     ]
 
 -- | Synthesize a random 'AbiValue' given its 'AbiType'. Doesn't use a dictionary.

lib/Echidna/SourceAnalysis/Slither.hs

@@ -115,7 +115,7 @@ instance FromJSON SlitherInfo where
           :: Map ContractName (Map FunctionName [[Maybe AbiValue]])
           <- o .: "constants_used" >>= (traverse . traverse . traverse . traverse) parseConstant
         -- flatten [[AbiValue]], the array probably shouldn't be nested, fix it in Slither
-        let constantValues = (fmap . fmap) (catMaybes . concat) constantValues'
+        let constantValues = (fmap . fmap) (concatMap catMaybes) constantValues'
         functionsRelations <- o .: "functions_relations"
         generationGraph <-
           (traverse . traverse) (withObject "relations" (.: "impacts")) functionsRelations

src/Main.hs

@@ -156,9 +156,9 @@ bool = maybeReader (f . map toLower) where
   f _ = Nothing
 
 options :: Parser Options
-options = Options
-  <$> (NE.fromList <$> some (argument str (metavar "FILES"
-    <> help "Solidity files to analyze")))
+options = Options . NE.fromList
+  <$> some (argument str (metavar "FILES"
+    <> help "Solidity files to analyze"))
   <*> optional (option auto $ long "workers"
     <> metavar "N"
     <> help "Number of workers to run")