fix: resolve inherited re-exported import aliases#3046
Open
ChargingFoxSec wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3019.
This resolves inherited import aliases that are re-exported from an imported file.
Root cause
resolve_remapping_and_renamingresolves direct import aliases, then falls back to the current file scope. When the inherited name is itself an alias re-exported from another imported file, the fallback does not continue through accessible imported scopes, so Slither fails with:AssertionError: Contract KeeperCompatibleInterface not foundChanges
Testing
uv run slither /tmp/slither-repro-3019/src/KeepersCounter.sol --compile-force-framework solc --solc-remaps @chainlink/=/tmp/slither-repro-3019/lib/chainlink-evm/ --disable-coloruv run pytest tests/e2e/solc_parsing/test_ast_parsing.py -k import_aliases_reexportuv run pytest tests/e2e/solc_parsing/test_ast_parsing.py -k "complex_imports/import_aliases/test.sol"uv run ruff check slither/solc_parsing/slither_compilation_unit_solc.py tests/e2e/solc_parsing/test_ast_parsing.pyuv run ruff format --check slither/solc_parsing/slither_compilation_unit_solc.py tests/e2e/solc_parsing/test_ast_parsing.py