Conversation
|
|
📊 Package size report 0.03%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
csandman
commented
Jan 9, 2026
| ref: | ||
| | ((instance: SelectInstance<Option, IsMulti, Group> | null) => void) | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated | ||
| | MutableRefObject<SelectInstance<Option, IsMulti, Group> | null> |
Owner
Author
There was a problem hiding this comment.
This is deprecated in React 19 in favor of the type RefObject. However, in React 18, RefObject has a different meaning, so I'm leaving it as-is for now in case the type change would cause type issues for anyone. Currently, the core react-select package still uses this type, so I'm going to follow their lead: https://github.com/JedWatson/react-select/blob/052e864/packages/react-select/src/stateManager.tsx#L29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR first updates all package versions in both the package and demo:
chakra-react-selectdemoFollowing that, it fixes anything that was deprecated or changed because of it. Similar to #371, I had to fix the vite config to get the demo working again:
While doing so, I also added
babel-plugin-react-compilerto start using the react compiler.Finally, it adds
eslint-plugin-unicornto both the package and demo for more opinionated type checking.