Skip to content

Method :has_required_attribute_presence? get wrong result. #267

Description

@hymanljw

In file lib/devise_ldap_authenticatable/ldap/connection.rb:213, method has_required_attribute_presence?

@required_attributes_presence.each do |key,val|
  if val && !user.attribute_names.include?(key.to_sym)
    DeviseLdapAuthenticatable::Logger.send("User #{dn} doesn't include attribute #{key}")
    return false
  elsif !val && user.attribute_names.include?(key.to_sym) # <= This looks like a wrong logic, run the method always get false.
    DeviseLdapAuthenticatable::Logger.send("User #{dn} includes attribute #{key}")
    return false
  end
end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions