Fix further code smells

Author: craigfowler

CSF.ORM.NHibernate.Common/EagerFetchingProvider.cs

@@ -132,7 +132,7 @@ public IQueryableWithEagerFetching<TQueried, TGrandchild> FetchGrandchildren<TQu
         static IQueryable<T> GetUnderlyingQueryIfAvailable<T>(IQueryable<T> query)
             => (query is IProvidesQueryable<T> queryProvider) ? queryProvider.GetQueryable() : query;
 
-        INhFetchRequest<TQueried, TFetched> GetNhFetchRequest<TQueried, TFetched>(IQueryable<TQueried> query)
+        static INhFetchRequest<TQueried, TFetched> GetNhFetchRequest<TQueried, TFetched>(IQueryable<TQueried> query)
             => GetUnderlyingQueryIfAvailable(query) as INhFetchRequest<TQueried, TFetched>;
 
     }

CSF.ORM.NHibernate4/LazyResultProvider.cs

@@ -30,6 +30,13 @@
 using NHibernate.Linq;
 using NhQueryProvider = NHibernate.Linq.DefaultQueryProvider;
 
+/* Note that SonarQube will mark this file up as being a duplicate of the NHibernate 5 version.
+ * They cannot be consolidated into the common project though, because the method signatures of
+ * the NH 4 & 5 versions of methods on the LinqExtensionMethods class are different.
+ *
+ * Trying to consolidate these two versions of the class leads to MissingMethodException errors.
+ */
+
 namespace CSF.ORM.NHibernate
 {
     /// <summary>

CSF.ORM.NHibernate5/LazyResultProvider.cs

@@ -30,6 +30,13 @@
 using NHibernate.Linq;
 using NhQueryProvider = NHibernate.Linq.DefaultQueryProvider;
 
+/* Note that SonarQube will mark this file up as being a duplicate of the NHibernate 4 version.
+ * They cannot be consolidated into the common project though, because the method signatures of
+ * the NH 4 & 5 versions of methods on the LinqExtensionMethods class are different.
+ *
+ * Trying to consolidate these two versions of the class leads to MissingMethodException errors.
+ */
+
 namespace CSF.ORM.NHibernate
 {
     /// <summary>

PersistenceTester/CSF.PersistenceTester.NUnit/Constraints/NotEqualResult.cs

@@ -18,7 +18,7 @@ public override void WriteMessageTo(MessageWriter writer)
                 WriteFailingRule(writer, failure);
         }
 
-        void WriteFailingRule(MessageWriter writer, EqualityRuleResult ruleResult)
+        static void WriteFailingRule(MessageWriter writer, EqualityRuleResult ruleResult)
         {
             if (ruleResult.Exception != null)
                 writer.WriteLine($"{RuleName(ruleResult)} Threw an unexpected exception whilst performing the comparison.{Environment.NewLine}{ruleResult.Exception}");