Tidy up actions usages

Author: craigfowler

.github/workflows/crossBrowserTesting.yml

@@ -8,7 +8,6 @@ on:
   workflow_run:
     workflows: [.NET CI]
     types: [completed]
-    branches: [master]
   schedule:
     - cron: "27 20 * * 0"
 
@@ -86,8 +85,10 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/restore-dependencies
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
 
       - name: Build the solution
         run: dotnet build -c ${{ env.Configuration }}

.github/workflows/dotnetCi.yml

@@ -26,10 +26,14 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/setup-test-dependencies
-      - uses: ./.github/actions/restore-dependencies
-      - uses: ./.github/actions/start-sonarscanner
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Setup additional test dependencies
+        uses: ./.github/actions/setup-test-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
+      - name: Start SonarScanner
+        uses: ./.github/actions/start-sonarscanner
         with:
           project: csf-dev_CSF.Screenplay
           build-version: GitHub_build_${{ env.RunNumber }}
@@ -39,14 +43,16 @@ jobs:
       - name: Build the solution
         run: dotnet build -c ${{ env.Configuration }} --no-incremental
       - id: run-all-tests
+        name: Run all tests, with coverage
         uses: ./.github/actions/run-all-tests-with-coverage
       - name: Stop SonarScanner
         run:
           dotnet sonarscanner end /d:sonar.token=${{ secrets.SONARCLOUDKEY }}
       - name: Gracefully stop Xvfb
         run: killall Xvfb
         continue-on-error: true
-      - uses: ./.github/actions/upload-ci-artifacts
+      - name: Upload all CI artifacts
+        uses: ./.github/actions/upload-ci-artifacts
       - name: Fail the build if any test failures
         if: steps.run-all-tests.outputs.failures == 'true'
         run: |

.github/workflows/publishDocsWebsite.yml

@@ -19,8 +19,10 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/restore-dependencies
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
       - name: Remove old docs
         run: dotnet clean CSF.Screenplay.Docs
       - name: Build new docs

.github/workflows/releaseBuild.yml

@@ -25,8 +25,10 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/restore-dependencies
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
       - name: Build CI version
         if: ${{ github.event_name == 'workflow_run' }}
         run: dotnet pack -p:VersionSuffix=ci.${{ github.run_number }} -o packages
@@ -66,8 +68,10 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/restore-dependencies
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
       - name: Remove old docs
         run: dotnet clean CSF.Screenplay.Docs
       - name: Build docs website

.github/workflows/supportVerification.yml

@@ -30,7 +30,9 @@ jobs:
         with:
           fetch-depth: 0
           lfs: true
-      - uses: ./.github/actions/setup-build-dependencies
-      - uses: ./.github/actions/restore-dependencies
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-dependencies
+      - name: Restore third party libs
+        uses: ./.github/actions/restore-dependencies
       - name: Test Reqnroll (only)
         run: dotnet test Tests/CSF.Screenplay.Reqnroll.Tests -p:ReqnrollVersion=${{ matrix.reqnroll_version }}