Merge pull request #289 from csf-dev/craigfowler/issue284

Resolve #284 - Open URL throws if the Url is not absolute

Author: craigfowler

CSF.Screenplay.Selenium/Actions/OpenUrl.cs

@@ -15,6 +15,8 @@ public class OpenUrl : IPerformable, ICanReport
         public ValueTask PerformAsAsync(ICanPerform actor, CancellationToken cancellationToken = default)
         {
             var ability = actor.GetAbility<BrowseTheWeb>();
+            if(!uri.Uri.IsAbsoluteUri)
+                throw new InvalidOperationException($"The URL to open must be absolute; have you forgotten to grant {actor} the {nameof(UseABaseUri)} ability?");
             ability.WebDriver.Url = uri.Uri.ToString();
             return default;
         }

Tests/CSF.Screenplay.Selenium.Tests/Actions/OpenUrlTests.cs

@@ -1,5 +1,7 @@
 
+using System;
 using CSF.Screenplay.Selenium.Elements;
+using OpenQA.Selenium;
 using static CSF.Screenplay.PerformanceStarter;
 using static CSF.Screenplay.Selenium.PerformableBuilder;
 
@@ -34,4 +36,22 @@ public async Task OpenTheUrlWithDifferentBasePathShouldYieldDifferentContent(ISt
 
         Assert.That(contents, Is.EqualTo("This is content at the deeper path."));
     }
+
+    [Test, AutoMoqData]
+    public async Task PerformAsAsyncShouldThrowIfTheUrlIsNotAbsolute(Actor actor,
+                                                                     [MockDriver] BrowseTheWeb ability)
+    {
+        actor.IsAbleTo(ability);
+        var sut = new OpenUrl(new NamedUri("foo/bar/baz.html"));
+        Assert.That(() => sut.PerformAsAsync(actor), Throws.InstanceOf<InvalidOperationException>());
+    }
+
+    [Test, AutoMoqData]
+    public async Task PerformAsAsyncShouldNotThrowIfTheUrlIsAbsolute(Actor actor,
+                                                                     [MockDriver] BrowseTheWeb ability)
+    {
+        actor.IsAbleTo(ability);
+        var sut = new OpenUrl(new NamedUri("https://example.com/foo/bar/baz.html"));
+        Assert.That(() => sut.PerformAsAsync(actor), Throws.Nothing);
+    }
 }

Tests/CSF.Screenplay.Selenium.Tests/MockDriverAttribute.cs

@@ -0,0 +1,23 @@
+using System.Reflection;
+using AutoFixture;
+using CSF.Extensions.WebDriver;
+using CSF.Extensions.WebDriver.Factories;
+using Moq;
+
+namespace CSF.Screenplay.Selenium;
+
+public class MockDriverAttribute : CustomizeAttribute
+{
+    public override ICustomization GetCustomization(ParameterInfo parameter)
+        => new MockDriverCustomization();
+}
+
+public class MockDriverCustomization : ICustomization
+{
+    public void Customize(IFixture fixture)
+    {
+        fixture.Customize<IGetsWebDriver>(c => c.FromFactory((WebDriverAndOptions d) => Mock.Of<IGetsWebDriver>(m => m.GetDefaultWebDriver(null) == d
+                                                                                                                  && m.GetWebDriver(It.IsAny<string>(), null) == d)));
+        fixture.Customize<BrowseTheWeb>(c => c.FromFactory((IGetsWebDriver d) => new BrowseTheWeb(d)));
+    }
+}