Skip to content

Commit 4a999db

Browse files
committed
Custom shells for tests
I found out that GitHub actions uses the fast-fail behaviour. So that means that it's not advancing past the first line of script that fails. So, all my failure handling logic is ineffective and not being executed. This should fix that by disabling fast-fail on these two steps.
1 parent 9875ab3 commit 4a999db

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/dotnetCi.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
run: dotnet build -c ${{ env.Configuration }} --no-incremental
105105
- name: Run .NET tests with coverage
106106
id: dotnet_tests
107-
continue-on-error: true
107+
shell: bash {0}
108108
run: |
109109
for proj in Tests/*.Tests
110110
do
@@ -121,7 +121,7 @@ jobs:
121121
done
122122
- name: Run JavaScript tests with coverage
123123
id: js_tests
124-
continue-on-error: true
124+
shell: bash {0}
125125
run: |
126126
cd CSF.Screenplay.JsonToHtmlReport.Template/src
127127
npm test

0 commit comments

Comments
 (0)