WIP #275 - Fix some technical issues

Author: craigfowler

CSF.Screenplay.Selenium/Color.cs

@@ -73,17 +73,13 @@ public readonly double Alpha
             init => this.alpha = SanitizeAlpha(value);
         }
 #else
-        public double Alpha
-        {
-            get => alpha;
-            private set => alpha = SanitizeAlpha(value);
-        }
+        public double Alpha { get => alpha; }
 #endif
 
         /// <summary>
         /// Gets a representation of <see cref="Alpha"/>, as a byte.
         /// </summary>
-        public byte AlphaAsByte => (byte) Math.Floor(Math.Round(Alpha * 255, 0));
+        public byte AlphaAsByte => (byte) Math.Floor(Math.Round(Alpha * 255, 0, MidpointRounding.AwayFromZero));
 
         /// <summary>
         /// Converts this color to a <see cref="System.Drawing.Color"/>.
@@ -104,7 +100,7 @@ public double Alpha
         public bool Equals(Color other) => other.Red == Red
                                         && other.Green == Green
                                         && other.Blue == Blue
-                                        && other.Alpha == Alpha;
+                                        && other.AlphaAsByte == AlphaAsByte;
 
         /// <inheritdoc/>
         public bool Equals(string other) => TryParse(other, out var color) && Equals(color);

CSF.Screenplay.Selenium/Colors.cs

@@ -20,7 +20,7 @@ public static class Colors
         /// Caches the named colors and their names, for performance reasons when using <see cref="GetNamedColor(string)"/> and/or
         /// <see cref="TryGetNamedColor(string, out Color)"/>.
         /// </summary>
-        static readonly ReadOnlyDictionary<string,Color> namedColors;
+        static readonly ReadOnlyDictionary<string,Color> namedColors = GetNamedColorCache();
 
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
         public static Color TRANSPARENT => new Color(0, 0, 0, 0);
@@ -219,14 +219,21 @@ public static bool TryGetNamedColor(string colorName, out Color color)
         }
 
         /// <summary>
-        /// Static constructor initializes a cache of the named colors.
+        /// Gets a dictionary of the names/instances of the well-known colors.
         /// </summary>
-        static Colors()
+        /// <remarks>
+        /// <para>
+        /// The keys of this dictionary are case insensitive and correspond to the names of the static properties of this type.
+        /// The values are instances of the <see cref="Color"/> that the corresponding property returns.
+        /// </para>
+        /// </remarks>
+        /// <returns>A cache of the named color values.</returns>
+        static ReadOnlyDictionary<string, Color> GetNamedColorCache()
         {
             var namedColorValues = typeof(Colors)
                 .GetProperties(BindingFlags.Static)
                 .ToDictionary(k => k.Name, v => (Color) v.GetValue(null), StringComparer.InvariantCultureIgnoreCase);
-            namedColors = new ReadOnlyDictionary<string, Color>(namedColorValues);
+            return new ReadOnlyDictionary<string, Color>(namedColorValues);
         }
    }
 }