Further test coverage

Author: craigfowler

CSF.Screenplay.Selenium/Actions/OpenUrl.cs

@@ -15,13 +15,13 @@ public class OpenUrl : IPerformable, ICanReport
         public ValueTask PerformAsAsync(ICanPerform actor, CancellationToken cancellationToken = default)
         {
             var ability = actor.GetAbility<BrowseTheWeb>();
-            ability.WebDriver.Url = uri.Uri.AbsoluteUri;
+            ability.WebDriver.Url = uri.Uri.ToString();
             return default;
         }
 
         /// <inheritdoc/>
         public ReportFragment GetReportFragment(Actor actor, IFormatsReportFragment formatter)
-            => formatter.Format("{Actor} opens their browser at {UriName}: {Uri}", actor.Name, uri.Name, uri.Uri.AbsoluteUri);
+            => formatter.Format("{Actor} opens their browser at {UriName}: {Uri}", actor.Name, uri.Name, uri.Uri.ToString());
 
         /// <summary>
         /// Initializes a new instance of the <see cref="OpenUrl"/> class with the specified URL.

Tests/CSF.Screenplay.Selenium.Tests/NamedUriTests.cs

@@ -1,3 +1,6 @@
+using System;
+using CSF.Screenplay.Selenium;
+
 namespace CSF.Screenplay.Selenium;
 
 [TestFixture, Parallelizable]
@@ -26,4 +29,32 @@ public void RebaseToShouldReturnAUriWithTheSameName()
         var rebased = sut.RebaseTo("https://example.com");
         Assert.That(rebased.Name, Is.EqualTo("name"));
     }
+
+    [Test]
+    public void RebaseToShouldThrowIfUriIsNull()
+    {
+        var sut = new NamedUri("test.html", "name");
+        Assert.That(() => sut.RebaseTo(null), Throws.ArgumentNullException);
+    }
+
+    [Test]
+    public void RebaseToShouldThrowIfUriIsNullString()
+    {
+        var sut = new NamedUri("test.html", "name");
+        Assert.That(() => sut.RebaseTo((string?) null), Throws.ArgumentNullException);
+    }
+
+    [Test]
+    public void ImplicitCastFromUriShouldCreateANamedUri()
+    {
+        NamedUri uri = new Uri("https://example.com/foo.html");
+        Assert.That(uri.Uri.ToString(), Is.EqualTo("https://example.com/foo.html"));
+    }
+
+    [Test]
+    public void ImplicitCastFromStringShouldCreateANamedUri()
+    {
+        NamedUri uri = "https://example.com/foo.html";
+        Assert.That(uri.Uri.ToString(), Is.EqualTo("https://example.com/foo.html"));
+    }
 }

Tests/CSF.Screenplay.Selenium.Tests/Tasks/OpenUrlRespectingBaseTests.cs

@@ -49,4 +49,39 @@ public async Task TheActionCreatedByThisTaskShouldContainTheCorrectReport(IWebDr
             actor.EndPerformable -= OnPerform;
         }
     }
+
+    [Test, AutoMoqData]
+    public async Task TheActionCreatedByThisTaskShouldContainTheCorrectReportWhenTheActorDoesNotHaveABaseUrl(IWebDriver driver, DriverOptions options)
+    {
+        var actor = new Actor("Anthony", Guid.NewGuid());
+        IPerformable? performable = null;
+
+        void OnPerform(object? sender, PerformableEventArgs ev) => performable = (IPerformable)ev.Performable;
+
+        var namedUri = new NamedUri("test.html", "the test page");
+        actor.IsAbleTo(new BrowseTheWeb(Mock.Of<IGetsWebDriver>(x => x.GetDefaultWebDriver(It.IsAny<Action<DriverOptions>>()) == new WebDriverAndOptions(driver, options))));
+        var sut = new OpenUrlRespectingBase(namedUri);
+        var valueFormatterProvider = new ValueFormatterProvider(new ServiceCollection().AddTransient<ToStringFormatter>().BuildServiceProvider(),
+                                                                new ValueFormatterRegistry { typeof(ToStringFormatter) });
+        
+        var formatter = new ReportFragmentFormatter(new ReportFormatCreator(), valueFormatterProvider);
+
+        actor.EndPerformable += OnPerform;
+        try
+        {
+            await sut.PerformAsAsync(actor);
+
+            Assert.Multiple(() =>
+            {
+                Assert.That(performable, Is.InstanceOf<OpenUrl>(), "Performable is correct type");
+                Assert.That(((OpenUrl) performable!).GetReportFragment(actor, formatter).ToString(),
+                            Is.EqualTo("Anthony opens their browser at the test page: test.html"),
+                            "The report is correct");
+            });
+        }
+        finally
+        {
+            actor.EndPerformable -= OnPerform;
+        }
+    }
 }