Skip to content

Commit 7f4109e

Browse files
committed
WIP #248 - Give up on building in one TFM
I can't seem to make this work with tests, so I'm going to abandon the idea. It was a nice-to-have not important.
1 parent f823493 commit 7f4109e

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

.github/workflows/dotnetCi.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@ jobs:
1313
# * Installs and configures the environment
1414
# * Builds the solution with SonarScanner analysis
1515
# * In Debug configuration
16-
# * For just one TFM (typically the latest LTS .NET release)
1716
# * Runs all .NET and JS tests
1817
# * In Debug configuration (.NET tests)
1918
# * Producing code coverage reports, consumed by SonarScanner
20-
# * For just one TFM (typically the latest LTS .NET release)
2119
# * WebDriver-based tests use a locally-running Chrome browser ONLY
2220
# * Packages test results as build artifacts
2321
# * Builds & packs the solution in Release configuration
@@ -68,7 +66,7 @@ jobs:
6866
- name: Install GUI packages so Chrome may run
6967
run: |
7068
sudo apt-get update
71-
sudo apt install -y xorg xvfb gtk2-engines-pixbuf dbus-x11 xfonts-base xfonts-100dpi xfonts-75dpi xfonts-cyrillic xfonts-scalable
69+
sudo apt install -y xorg xvfb gtk2-engines-pixbuf dbus-x11 xfonts-base xfonts-100dpi xfonts-75dpi xfonts-cyrillic xfonts-scalable psmisc
7270
7371
# Environment setup pre-build
7472

@@ -99,8 +97,8 @@ jobs:
9997
/d:${{ env.BranchParam }}=${{ env.BranchName }} ${{ env.PullRequestParam }}
10098
/d:sonar.javascript.lcov.reportPaths=CSF.Screenplay.JsonToHtmlReport.Template/src/TestResults/lcov.info
10199
/s:$PWD/.sonarqube-analysisproperties.xml
102-
- name: Build the solution (one TFM only for performance)
103-
run: dotnet build -c ${{ env.Configuration }} --no-incremental -p:TargetFrameworks=${{ env.Tfm }}
100+
- name: Build the solution
101+
run: dotnet build -c ${{ env.Configuration }} --no-incremental
104102
- name: Run .NET tests with coverage
105103
id: dotnet_tests
106104
continue-on-error: true

0 commit comments

Comments
 (0)