Skip to content

Commit 965ab52

Browse files
committed
Fixup actions
The failure condition was incorrect, and the TFM on the tests was wrong, too.
1 parent bcc39dd commit 965ab52

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.github/actions/run-all-tests-with-coverage/action.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,11 @@ runs:
5252
fi
5353
- name: Emit output
5454
id: emit_output
55+
env:
56+
DotnetFailures: ${{ steps.dotnet_tests.outputs.failures }}
57+
JsFailures: ${{ steps.js_tests.outputs.failures }}
5558
run: |
56-
if [ ${{ steps.dotnet_tests.outputs.failures }} -eq 'true' -o ${{ steps.js_tests.outputs.failures }} -eq 'true' ]
59+
if [ "$DotnetFailures" -eq 'true' -o "$JsFailures" -eq 'true' ]
5760
then
5861
echo "failures=true" >> "$GITHUB_OUTPUT"
5962
else

.github/workflows/dotnetCi.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ jobs:
4545
- id: run-all-tests
4646
name: Run all tests, with coverage
4747
uses: ./.github/actions/run-all-tests-with-coverage
48+
with:
49+
tfm: ${{ env.Tfm }}
4850
- name: Stop SonarScanner
4951
run:
5052
dotnet sonarscanner end /d:sonar.token=${{ secrets.SONARCLOUDKEY }}

0 commit comments

Comments
 (0)