Clean up BrowserStack tests

* Remove detritus from old non-SDK integration
* Clean up some unused using statements
* Tidy up README docco (technique changes)
* Delete old unused YAML

Author: craigfowler

Tests/CSF.Screenplay.Selenium.Tests/Actions/ClearLocalStorageTests.cs

@@ -1,11 +1,4 @@
-
-using System;
-using CSF.Extensions.WebDriver;
-using CSF.Extensions.WebDriver.Factories;
-using CSF.Screenplay.Performables;
 using CSF.Screenplay.Selenium.Elements;
-using Moq;
-using OpenQA.Selenium;
 using static CSF.Screenplay.PerformanceStarter;
 using static CSF.Screenplay.Selenium.PerformableBuilder;
 

Tests/CSF.Screenplay.Selenium.Tests/Actions/OpenUrlTests.cs

@@ -1,7 +1,6 @@
 
 using System;
 using CSF.Screenplay.Selenium.Elements;
-using OpenQA.Selenium;
 using static CSF.Screenplay.PerformanceStarter;
 using static CSF.Screenplay.Selenium.PerformableBuilder;
 

Tests/CSF.Screenplay.Selenium.Tests/BrowserStack/BrowserStackDriverFactory.cs

@@ -26,6 +26,7 @@
     <PackageReference Include="System.Text.Json" Version="9.0.7" />
   </ItemGroup>
 
+  <!-- Activate BrowserStack CBT if this props file exists, find the original in the Tools directory -->
   <Import Project="BrowserStack.props" Condition="Exists('BrowserStack.props')" />
 
   <ItemGroup>
@@ -40,7 +41,6 @@
     <Content Include="appsettings.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
-    <Compile Remove="BrowserStack\**\*"/>
   </ItemGroup>
 
 </Project>

Tests/CSF.Screenplay.Selenium.Tests/BrowserStack/BrowserStackEnvironment.cs

@@ -1,5 +1,4 @@
 using System;
-using CSF.Screenplay.Selenium;
 
 namespace CSF.Screenplay.Selenium;
 

Tests/CSF.Screenplay.Selenium.Tests/BrowserStack/BrowserStackExtension.cs

@@ -46,18 +46,15 @@ The presence of this props file will activate two changes in the `.csproj` file
 * It will disable NUnit's parallelism feature
   * _When NUnit parallelism is enabled, it interferes with BrowserStack's own parallelism, creating confusing results_
 
-### Add a `browserstack.yml` configuration
+### Review the `browserstack.yml` configuration
 
 To use the BrowserStack SDK, you must provide a configuration file.
-The configuration file must be named `browserstack.yml` and it must be in the directory which contains the tests `.csproj` file _(IE: this directory, which contains this README file)_.
+There is a `browserstack.yml` already present in this directory but it is configured so that most of its settings are read from environment variables.
 
-There are seven sample configuration files available in the `Tools/` directory, which target seven different web browser/OS combinations.
-These happen to be the targets for the CBT CI run.
-You are welcome to copy one of these YAML files into the `CSF.Screenplay.Selenium.Tests` directory and rename it to `browserstack.yml`.
-Alternatively [you may craft your own BrowserStack configuration file].
-
-If you use one of the sample configurations, note that the `userName` and `accessKey` properties are omitted.
+You may wish to adjust the configuration file and replace the environment variable usage with selections of your own choice.
+Also note that the `userName` and `accessKey` properties are omitted in the provided configuration file, as these are secrets.
 _You will need to provide your own BrowserStack credentials_.
+Alternatively [you may craft your own BrowserStack configuration file].
 
 [you may craft your own BrowserStack configuration file]: https://www.browserstack.com/docs/automate/capabilities
 

Tests/CSF.Screenplay.Selenium.Tests/BrowserStack/BrowserStackSessionIdProvider.cs

@@ -1,4 +1,3 @@
-using CSF.Extensions.WebDriver;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;