Skip to content

Commit e6e4414

Browse files
committed
Back to non-verbose logging
Also add some docco, also exclude duplicate files from docs build.
1 parent 40f5d8d commit e6e4414

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

.github/workflows/dotnetCi.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ jobs:
147147
with:
148148
name: NUnit test results
149149
path: Tests/*.Tests/**/TestResults.xml
150+
# This step won't produce any artifacts if the verbose factory isn't
151+
# selected via appsettings.json in CSF.Screenplay.Selenium.Tests, but that's OK
150152
- name: Upload verbose webdriver log artifacts
151153
uses: actions/upload-artifact@v4
152154
with:

CSF.Screenplay.Docs/docfx.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"**/obj/**",
1212
"Tests/**",
1313
"Old/**",
14-
"CSF.Screenplay.JsonToHtmlReport.Template/**"
14+
"CSF.Screenplay.JsonToHtmlReport.Template/**",
15+
"CSF.Screenplay.SpecFlow/**"
1516
]
1617
}
1718
],

Tests/CSF.Screenplay.Selenium.Tests/VerboseChromeDriverFactory.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,16 @@
55

66
namespace CSF.Screenplay.Selenium;
77

8+
/// <summary>
9+
/// An implementation of <see cref="ICreatesWebDriverFromOptions"/> which writes verbose logs to a file.
10+
/// </summary>
11+
/// <remarks>
12+
/// <para>
13+
/// This driver factory is unused most of the time, but it's helpful if you're trying to diagnose problems with ChromeDriver,
14+
/// say in a CI build that's been failing. Select this factory by changing the <c>appsettings.json</c> file and you'll get
15+
/// log files.
16+
/// </para>
17+
/// </remarks>
818
public class VerboseChromeDriverFactory : ICreatesWebDriverFromOptions
919
{
1020
public WebDriverAndOptions GetWebDriver(WebDriverCreationOptions options, Action<DriverOptions> supplementaryConfiguration = null)

Tests/CSF.Screenplay.Selenium.Tests/appsettings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
"DriverFactoryType": "CSF.Screenplay.Selenium.VerboseChromeDriverFactory, CSF.Screenplay.Selenium.Tests"
1010
}
1111
},
12-
"SelectedConfiguration": "VerboseChrome"
12+
"SelectedConfiguration": "DefaultChrome"
1313
}
1414
}

0 commit comments

Comments
 (0)