Issue #352 - Improve the overall design of the reports#359
Merged
Conversation
This is a prototype/mockup design that I'm working on.
This is mainly about the main View Mode UI and also making the report somewhat responsive.
Also remove the feature/scenario IDs which we don't really have space to render in responsive mode.
Includes a lot of work on making the features view responsive. The redesign means that horizontal space has been saved on quite a few elements, so that the page works better on handheld browsers.
The icons to the right of the report were too small in mobile layouts. This makes them larger. I've opened #358 to add a compressed mode which will resize them back to 1em.
I should audit the test coverage after this has built. I wonder if there's anything I should improve upon. Also, as part of this, I upgraded Jest to latest.
This is getting large enough that I could really use type support for my JS. This is now set up so that the project builds OK and tests run OK.
Since I last tried Flow out 6-8 years ago, it has decidedly lost the battle for adoption to TypeScript. I've found it outdated and struggling to keep up with the JS ecosystem since I added it to this project. As such I'm stripping Flow back out and I will switch to TS in a forthcoming commit.
Flow for JS is out of favour in the open-source world. It has been largely abandoned by the community in favour of TypeScript. So, that's no longer a good choice for this project. Given I'm switching one client tech, I also revisited another: Webpack & Babel. I've now dropped both of thos in favour of Vite, which is more modern and supports TS out of the box. TS has better dev & authoring support too. This also led me to drop Jest in favour of Vitest. This commit completes the pivot away to those other techniques. The project is now at the point where everything builds and passes tests correctly once again. A few files are yet to be converted to TS.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly about introducing a new concept of a "view mode". At present the only one I support is "Features and scenarios" but I have plenty of upcoming issues in which I want to allow the user to read reports in other ways. This should make it possible to get maximum value from reports, such as diagnosing errors, diagnosing performance issues, accessing assets etc.
This also brings many improvements which make it easier to read the reports on handheld devices.
Resolve #352.