Resolve #356 fix unwanted log collection#361
Merged
Merged
Conversation
Turns out that I need to use session storage, because Firefox won't allow me to access `globalThis` (IE: `window`) from the WebDriver. Session storage is a decent place to keep the logs until they are recovered.
It seems that perhaps remote WebDriver is not the problem here, and it might relate to the use of `globalThis`, which I've discovered to be unreliable. I'm going to try removing this restriction to see if the problems I experienced were actually caused by something else. It might be I can support remote drivers with this technique after all.
Removed the static method NeedsJavaScriptWorkaroundForLogs that checks for WebDriver quirks related to log retrieval. It's no longer required.
craigfowler
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #356.