Add webforms-runner skill, fix migration scripts, update Run 06 report

csharpfritz · Copilot · csharpfritz · commit 25f2d3640144 · 2026-03-09T09:35:10.000-04:00
- Add webforms-runner skill for IIS Express + Playwright screenshots
- Fix OnClick conversion in bwfc-migrate.ps1 (keep OnClick for BWFC Button)
- Add AddHttpContextAccessor to Layer 2 Program.cs generation
- Update migration-standards skill with BwfcProjectPath, database provider rules
- Add unsupported controls section to Run 06 report

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/.ai-team/decisions/inbox/copilot-directive-2026-03-09-migration-fixes.md b/.ai-team/decisions/inbox/copilot-directive-2026-03-09-migration-fixes.md
@@ -0,0 +1,12 @@
+### 2026-03-09: Migration tooling directives
+**By:** Jeff Fritz (via Copilot)
+**What:**
+1. **Project reference argument** — Always use `-BwfcProjectPath` when running migrations in test mode
+2. **OnClick pattern** — Follow documented pattern (BWFC Button uses `OnClick` not `@onclick`)
+3. **Database provider** — Strong preference to maintain same provider (e.g., localdb) unless explicitly directed otherwise
+4. **EF6 → EF Core cleanup** — Need post-migration cleanup scripts
+5. **Unsupported controls** — Always list in migration reports for library prioritization
+6. **AddHttpContextAccessor** — ALWAYS add to Program.cs in every migration
+7. **ItemType parameter** — Investigate what's actually wrong (GridView/BoundField need explicit type)
+
+**Why:** Run 06 revealed script gaps that should have been caught. These are permanent rules for the migration toolkit.
diff --git a/.github/skills/webforms-runner/SKILL.md b/.github/skills/webforms-runner/SKILL.md
@@ -0,0 +1,228 @@
+---
+name: webforms-runner
+description: "**WORKFLOW SKILL** - Starts ASP.NET Web Forms applications using IIS Express and captures screenshots with Playwright. USE FOR: running WebForms samples, capturing 'before' screenshots for migration documentation, testing original Web Forms applications. DO NOT USE FOR: running Blazor apps (use dotnet run), running .NET Core apps (use dotnet CLI). INVOKES: IIS Express CLI, Playwright MCP browser tools."
+---
+
+# WebForms Runner Skill
+
+This skill enables running ASP.NET Web Forms applications using IIS Express and capturing screenshots with Playwright for documentation purposes.
+
+## Prerequisites
+
+- **IIS Express** installed (typically at `C:\Program Files (x86)\IIS Express\iisexpress.exe`)
+- **Visual Studio Build Tools** or **Visual Studio** (for MSBuild)
+- **.NET Framework 4.x** installed
+- **Playwright MCP tools** available (browser_navigate, browser_snapshot, browser_take_screenshot)
+
+## Available Web Forms Samples
+
+This repository contains two Web Forms sample applications:
+
+| Sample | Path | Port | Database |
+|--------|------|------|----------|
+| **ContosoUniversity** | `samples/ContosoUniversity/ContosoUniversity/` | 52477 | SQL Server LocalDB |
+| **WingtipToys** | `samples/WingtipToys/WingtipToys/` | 44300 | SQL Server LocalDB |
+
+## Starting a Web Forms Application
+
+### Step 1: Build the Project
+
+Web Forms projects require MSBuild (not `dotnet build`):
+
+```powershell
+# ContosoUniversity
+msbuild "samples\ContosoUniversity\ContosoUniversity\ContosoUniversity.csproj" /p:Configuration=Debug /t:Build /v:m
+
+# WingtipToys  
+msbuild "samples\WingtipToys\WingtipToys\WingtipToys.csproj" /p:Configuration=Debug /t:Build /v:m
+```
+
+If NuGet packages are missing, restore first:
+```powershell
+nuget restore "samples\ContosoUniversity\ContosoUniversity.sln"
+```
+
+### Step 2: Start IIS Express
+
+Use the `/path` option to run directly from the project folder:
+
+```powershell
+# ContosoUniversity (port 52477)
+& "C:\Program Files (x86)\IIS Express\iisexpress.exe" /path:"D:\BlazorWebFormsComponents\samples\ContosoUniversity\ContosoUniversity" /port:52477
+
+# WingtipToys (port 44300)
+& "C:\Program Files (x86)\IIS Express\iisexpress.exe" /path:"D:\BlazorWebFormsComponents\samples\WingtipToys\WingtipToys" /port:44300
+```
+
+**Important:** Run IIS Express in async mode with `detach: true` since it's a server process:
+```
+mode: "async", detach: true
+```
+
+### Step 3: Verify the Site is Running
+
+Wait 3-5 seconds for startup, then check with:
+```powershell
+curl http://localhost:52477 -UseBasicParsing | Select-Object -ExpandProperty StatusCode
+```
+
+## IIS Express Command Reference
+
+```
+iisexpress.exe [options]
+
+Key options:
+  /path:app-path         Physical path to the application folder
+  /port:port-number      Port to bind (default: 8080)
+  /clr:clr-version       .NET Framework version (e.g., v4.0)
+  /systray:true|false    Show system tray icon (default: true)
+```
+
+## Capturing Screenshots with Playwright
+
+Use the Playwright MCP tools to capture screenshots of the running Web Forms application.
+
+### Workflow for Documentation Screenshots
+
+1. **Navigate to the page:**
+   ```
+   playwright-browser_navigate: { url: "http://localhost:52477/Home.aspx" }
+   ```
+
+2. **Wait for page load:**
+   ```
+   playwright-browser_wait_for: { time: 2 }
+   ```
+
+3. **Take a snapshot (for accessibility tree):**
+   ```
+   playwright-browser_snapshot: {}
+   ```
+
+4. **Take a screenshot:**
+   ```
+   playwright-browser_take_screenshot: { 
+     filename: "dev-docs/screenshots/webforms-home.png",
+     type: "png"
+   }
+   ```
+
+### ContosoUniversity Pages
+
+| Page | URL | Screenshot Name |
+|------|-----|-----------------|
+| Home | `/Home.aspx` | `contoso-webforms-home.png` |
+| Students | `/Students.aspx` | `contoso-webforms-students.png` |
+| Courses | `/Courses.aspx` | `contoso-webforms-courses.png` |
+| Instructors | `/Instructors.aspx` | `contoso-webforms-instructors.png` |
+| About | `/About.aspx` | `contoso-webforms-about.png` |
+
+### WingtipToys Pages
+
+| Page | URL | Screenshot Name |
+|------|-----|-----------------|
+| Home | `/Default.aspx` | `wingtip-webforms-home.png` |
+| Products | `/ProductList.aspx?ProductCategory=1` | `wingtip-webforms-products.png` |
+| Product Detail | `/ProductDetails.aspx?ProductID=1` | `wingtip-webforms-detail.png` |
+| Cart | `/ShoppingCart.aspx` | `wingtip-webforms-cart.png` |
+
+### Screenshot Best Practices
+
+1. **Use consistent naming:** `{app}-webforms-{page}.png` for before, `{app}-blazor-{page}.png` for after
+2. **Save to documentation folder:** `dev-docs/migration-tests/{run}-screenshots/`
+3. **Capture full page when needed:** Use `fullPage: true` for long pages
+4. **Wait for dynamic content:** Add `browser_wait_for` before screenshots if page has AJAX
+
+## Complete Example: ContosoUniversity Screenshots
+
+```powershell
+# 1. Build the project
+msbuild "samples\ContosoUniversity\ContosoUniversity\ContosoUniversity.csproj" /p:Configuration=Debug /t:Build /v:m
+
+# 2. Start IIS Express (async, detached)
+# Use powershell tool with mode: "async", detach: true
+& "C:\Program Files (x86)\IIS Express\iisexpress.exe" /path:"D:\BlazorWebFormsComponents\samples\ContosoUniversity\ContosoUniversity" /port:52477
+
+# 3. Wait for startup
+Start-Sleep -Seconds 5
+
+# 4. Use Playwright MCP tools to capture screenshots:
+#    - browser_navigate to http://localhost:52477/Home.aspx
+#    - browser_wait_for time: 2
+#    - browser_take_screenshot filename: "dev-docs/contoso-screenshots/webforms-home.png"
+#    - Repeat for each page
+
+# 5. Stop IIS Express when done
+# Find the process ID from the async shell output
+Stop-Process -Id <PID>
+```
+
+## Stopping IIS Express
+
+Since IIS Express runs as a detached process, you need to stop it by PID:
+
+```powershell
+# Find IIS Express processes
+Get-Process | Where-Object { $_.ProcessName -eq "iisexpress" }
+
+# Stop by specific PID
+Stop-Process -Id <PID>
+
+# Or stop all IIS Express instances
+Get-Process -Name "iisexpress" -ErrorAction SilentlyContinue | Stop-Process
+```
+
+## Troubleshooting
+
+### Port Already in Use
+```powershell
+# Check what's using the port
+Get-NetTCPConnection -LocalPort 52477 -ErrorAction SilentlyContinue
+
+# Kill the process
+Stop-Process -Id (Get-NetTCPConnection -LocalPort 52477).OwningProcess
+```
+
+### Missing NuGet Packages
+```powershell
+# Restore packages for the solution
+nuget restore "samples\ContosoUniversity\ContosoUniversity.sln"
+```
+
+### Database Connection Issues
+- Ensure SQL Server LocalDB is installed and running
+- Check connection string in `Web.config`
+- LocalDB instances can be started with: `sqllocaldb start MSSQLLocalDB`
+
+### MSBuild Not Found
+Add Visual Studio MSBuild to PATH or use full path:
+```powershell
+& "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" project.csproj
+```
+
+## Side-by-Side Screenshots for Migration Documentation
+
+When creating migration documentation, capture both WebForms and Blazor screenshots:
+
+```
+dev-docs/migration-tests/wingtiptoys-run15-screenshots/
+├── webforms-home.png       # Before (WebForms)
+├── blazor-home.png         # After (Blazor)
+├── webforms-products.png
+├── blazor-products.png
+└── ...
+```
+
+This allows creating visual comparisons in migration reports showing the fidelity of the conversion.
+
+## Integration with Migration Workflow
+
+1. **Before migration:** Start WebForms app, capture baseline screenshots
+2. **Run migration:** Execute bwfc-migrate.ps1 and bwfc-migrate-layer2.ps1
+3. **After migration:** Start Blazor app (`dotnet run`), capture result screenshots
+4. **Document:** Create side-by-side comparison in migration report
+
+## Related Skills
+
+- **webforms-migration** - For migrating ASPX/ASCX files to Blazor
+- **documentation** - For writing migration reports with screenshots
diff --git a/dev-docs/migration-tests/contoso-run06.md b/dev-docs/migration-tests/contoso-run06.md
@@ -116,6 +116,50 @@ Run 05 documentation updated with Blazor implementation screenshots:
 - `dev-docs/migration-tests/contoso-run05-screenshots/` — 5 Blazor screenshots
 - This report
 
+## Unsupported Controls Encountered
+
+The following Web Forms controls are used in ContosoUniversity but are **not supported** by BlazorWebFormsComponents. These should be prioritized for potential library additions or documented as requiring manual migration.
+
+### `<ajaxToolkit:AutoCompleteExtender>`
+
+| Attribute | Value |
+|-----------|-------|
+| **Used In** | Students.aspx, Courses.aspx |
+| **Purpose** | Provides typeahead/autocomplete functionality for TextBox controls. Calls a server-side `ServiceMethod` to fetch suggestions as the user types. |
+| **Configuration** | `MinimumPrefixLength="1"`, `CompletionInterval="100"`, `EnableCaching="true"`, `CompletionSetCount="20"` |
+| **Blazor Alternative** | Use a custom autocomplete component with `@oninput` event, debouncing, and async data fetching. Consider third-party libraries like MudBlazor `<MudAutocomplete>` or Radzen `<RadzenAutoComplete>`. |
+
+### `<asp:ScriptManager>`
+
+| Attribute | Value |
+|-----------|-------|
+| **Used In** | Students.aspx, Courses.aspx, Instructors.aspx |
+| **Purpose** | Required by ASP.NET AJAX to manage client script libraries, partial page rendering, and client proxy generation for web services. |
+| **Blazor Alternative** | **Not needed.** Blazor handles all JavaScript interop and component updates natively. Simply remove this control during migration. |
+
+### `<asp:UpdatePanel>`
+
+| Attribute | Value |
+|-----------|-------|
+| **Used In** | Students.aspx, Courses.aspx, Instructors.aspx |
+| **Purpose** | Enables partial page updates without full postbacks. Content inside `<ContentTemplate>` is updated asynchronously via AJAX. |
+| **Blazor Alternative** | **Not needed.** Blazor's component model handles partial updates automatically. Any state change triggers a re-render of only the affected components. Remove the UpdatePanel wrapper and migrate the inner content directly. |
+
+### Summary Table
+
+| Control | Pages | Priority | Recommendation |
+|---------|-------|----------|----------------|
+| `AutoCompleteExtender` | Students.aspx, Courses.aspx | **P2** | Consider BWFC implementation or document 3rd-party alternatives |
+| `ScriptManager` | Students.aspx, Courses.aspx, Instructors.aspx | **N/A** | Remove — not needed in Blazor |
+| `UpdatePanel` | Students.aspx, Courses.aspx, Instructors.aspx | **N/A** | Remove — Blazor handles this natively |
+
+### Migration Script Recommendation
+
+The Layer 1 migration script should:
+1. **Remove** `<asp:ScriptManager>` tags completely
+2. **Remove** `<asp:UpdatePanel>` wrappers (preserve `<ContentTemplate>` children)
+3. **Comment out** `<ajaxToolkit:*>` controls with a `<!-- BWFC: Unsupported control, manual migration required -->` warning
+
 ## Next Steps
 
 1. **P0:** Fix Layer 1 script @onclick → OnClick transform
diff --git a/migration-toolkit/scripts/bwfc-migrate-layer2.ps1 b/migration-toolkit/scripts/bwfc-migrate-layer2.ps1
@@ -1174,6 +1174,7 @@ function Invoke-PatternC {
     [void]$sb.AppendLine('')
     [void]$sb.AppendLine('builder.Services.AddRazorComponents();')
     [void]$sb.AppendLine('')
+    [void]$sb.AppendLine('builder.Services.AddHttpContextAccessor();  // Required for BWFC GridView/DetailsView')
     [void]$sb.AppendLine('builder.Services.AddBlazorWebFormsComponents();')
     [void]$sb.AppendLine('')
 
diff --git a/migration-toolkit/scripts/bwfc-migrate.ps1 b/migration-toolkit/scripts/bwfc-migrate.ps1
@@ -1533,22 +1533,22 @@ function Remove-WebFormsAttributes {
 function ConvertFrom-ButtonOnClick {
     <#
     .SYNOPSIS
-        Converts Web Forms OnClick="HandlerName" to Blazor @onclick="HandlerName" on Button elements.
+        Preserves Web Forms OnClick="HandlerName" on BWFC Button elements.
     .DESCRIPTION
         In Web Forms, <asp:Button OnClick="btnSubmit_Click"> wires the button to a server-side handler.
-        In Blazor, this becomes <Button @onclick="btnSubmit_Click">.
+        BWFC Button components use OnClick as an EventCallback parameter, so the attribute is preserved
+        as-is (no conversion to @onclick needed).
         
-        This function finds OnClick attributes on Button/LinkButton/ImageButton elements and converts 
-        them to @onclick. A manual item is logged reminding the developer to add the handler stub
-        in the code-behind if it doesn't already exist.
+        This function logs OnClick handlers found on Button/LinkButton/ImageButton elements and reminds
+        the developer to verify the handler signature in the code-behind.
     #>
     param(
         [string]$Content,
         [string]$RelPath
     )
 
     # Match OnClick="HandlerName" within Button, LinkButton, or ImageButton tags (after asp: prefix removal)
-    # This regex captures the handler name and replaces OnClick with @onclick
+    # BWFC uses OnClick as an EventCallback parameter, so we keep it as-is
     $onClickRegex = [regex]'(<(?:Button|LinkButton|ImageButton)\s+[^>]*?)OnClick="([^"]+)"'
     $onClickMatches = $onClickRegex.Matches($Content)
     
@@ -1558,13 +1558,13 @@ function ConvertFrom-ButtonOnClick {
             $handlers += $m.Groups[2].Value
         }
         
-        $Content = $onClickRegex.Replace($Content, '$1@onclick="$2"')
-        Write-TransformLog -File $RelPath -Transform 'ButtonHandler' -Detail "Converted $($onClickMatches.Count) OnClick to @onclick"
+        # No replacement needed - BWFC Button uses OnClick as EventCallback parameter
+        Write-TransformLog -File $RelPath -Transform 'ButtonHandler' -Detail "Found $($onClickMatches.Count) OnClick handler(s) — preserved for BWFC EventCallback"
         
         # Log unique handlers as manual items for verification
         $uniqueHandlers = $handlers | Select-Object -Unique
         foreach ($h in $uniqueHandlers) {
-            Write-ManualItem -File $RelPath -Category 'ButtonHandler' -Detail "Converted OnClick=""$h"" → @onclick=""$h"". Verify handler exists in code-behind as: private void $h() { }"
+            Write-ManualItem -File $RelPath -Category 'ButtonHandler' -Detail "OnClick=""$h"" preserved. Verify handler exists in code-behind as: private void $h(MouseEventArgs e) { }"
         }
     }
 
diff --git a/migration-toolkit/skills/migration-standards/SKILL.md b/migration-toolkit/skills/migration-standards/SKILL.md
@@ -52,12 +52,12 @@ The Layer 1 script's `Add-NavLinkIds` function handles this automatically.
 
 ```razor
 @* WRONG — direct child causes build error *@
-<GridView DataSource="@data">
+<GridView Items="@data">
     <BoundField DataField="Name" HeaderText="Name" />
 </GridView>
 
 @* RIGHT — wrapped in Columns *@
-<GridView DataSource="@data">
+<GridView Items="@data">
     <Columns>
         <BoundField DataField="Name" HeaderText="Name" />
     </Columns>
@@ -440,12 +440,20 @@ The migration pipeline uses **two scripts** plus targeted manual overlay:
 - ReadOnly attribute warnings
 - Logout form → link conversion
 
-**`-TestMode` switch:** Generates `ProjectReference` to local BWFC source instead of NuGet `PackageReference`, enabling rapid iteration during development runs:
+**`-TestMode` switch:** Generates `ProjectReference` to local BWFC source instead of NuGet `PackageReference`, enabling rapid iteration during development runs.
+
+**`-BwfcProjectPath` parameter:** When using `-TestMode`, always specify the path to the local BWFC source:
 
 ```powershell
+# WRONG — TestMode without BwfcProjectPath may fail to locate BWFC source
 pwsh -File bwfc-migrate.ps1 -Path <source> -Output <target> -TestMode
+
+# RIGHT — always specify BwfcProjectPath when testing in-repo samples
+pwsh -File bwfc-migrate.ps1 -Path <source> -Output <target> -TestMode -BwfcProjectPath "D:\BlazorWebFormsComponents\src\BlazorWebFormsComponents"
 ```
 
+**Database provider preference:** Maintain the original database provider from the source project unless explicitly directed otherwise. If the source uses SQL Server LocalDB, keep LocalDB in the migrated project. Only switch providers (e.g., to SQLite) when specifically requested.
+
 #### Layer 2 — `bwfc-migrate-layer2.ps1`
 
 The Layer 2 script targets three patterns of semantic transforms:
