Skip to content

Commit 453e23a

Browse files
csharpfritzcsharpfritz
committed
feat: add DataBinder & ViewState sample pages, alphabetize all navigation
- Create DataBinder sample: Eval(), shorthand Eval, formatted Eval, modern alternative - Create ViewState sample: dictionary API with counter demo, settings form, modern alternative - Alphabetize all NavMenu TreeView branches, ComponentList columns, and mkdocs.yml nav - Move ImageMap from Editor Controls to Navigation Controls in ComponentList and mkdocs - Add Utility Features section to ComponentList with all 4 entries - Add 4 integration tests: 2 smoke + 2 interaction (120/120 passing)
1 parent 4c9ac45 commit 453e23a

9 files changed

Lines changed: 512 additions & 6 deletions

File tree

‎.ai-team/agents/colossus/history.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,16 @@ Fixed all 7 failing integration tests. 111/111 passing after fixes.
8888
- Pages with multiple PasswordRecovery instances require ID-specific selectors (`#PasswordRecovery1_SubmitButton`) not suffix selectors (`input[id$='_SubmitButton']`) to avoid strict mode violations.
8989
- After a multi-step Blazor Server form flow, the final `_statusMessage` reflects the LAST handler that sets it. For PasswordRecovery step 2→3, `OnVerifyingAnswer` sets one message, then `OnSendingMail` overwrites it — test must assert on the final value.
9090
- `PressSequentiallyAsync` + Tab blur works reliably for Blazor Server `InputText` binding on dynamically re-rendered DOM elements.
91+
92+
## 2026-02-12: DataBinder and ViewState utility feature integration tests
93+
94+
- Added smoke tests in `ControlSampleTests.cs`:
95+
- New "Utility Features" theory section with `[InlineData("/ControlSamples/DataBinder")]` and `[InlineData("/ControlSamples/ViewState")]`
96+
- Added 2 interaction tests in `InteractiveComponentTests.cs`:
97+
- `DataBinder_Eval_RendersProductData` — verifies the DataBinder sample page renders product data ("Laptop Stand", "USB-C Hub", "Mechanical Keyboard") via Repeater with DataBinder.Eval(). Asserts at least 3 `<tbody tr>` rows present.
98+
- `ViewState_Counter_IncrementsOnClick` — verifies the ViewState sample page's "Click Me (ViewState)" button increments a counter stored in ViewState. Clicks twice and verifies counter reaches 1 then 2.
99+
- Build: 0 errors. All 120 integration tests passing (116 existing + 4 new), 0 failures.
100+
- Key learnings:
101+
- DataBinder sample uses `OnAfterRender(firstRender)` to call `DataBind()` on 4 Repeater instances — data only appears after first render, but NetworkIdle wait handles this.
102+
- ViewState sample button text "Click Me (ViewState)" distinguishes it from the "Click Me (Property)" button in section 3. Used `GetByRole(AriaRole.Button, new() { Name = "Click Me (ViewState)" })` for precise targeting.
103+
- Both pages include `<pre><code>` blocks with sample code — assertions use `page.ContentAsync()` for text presence rather than strict locators to avoid matching code samples vs rendered content where appropriate.

‎.ai-team/agents/jubilee/history.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,11 @@
4343

4444
📌 Team update (2026-02-12): Sprint 3 gate review — DetailsView and PasswordRecovery APPROVED. 50/53 components (94%). — decided by Forge
4545
📌 Team update (2026-02-12): LoginControls sample pages MUST include `@using BlazorWebFormsComponents.LoginControls` — root _Imports.razor doesn't cover sub-namespaces. Never use external image URLs in samples; use local SVGs. — decided by Colossus
46+
47+
### Utility Feature Sample Pages — DataBinder and ViewState
48+
49+
- **DataBinder sample** (`Components/Pages/ControlSamples/DataBinder/Index.razor`): Demonstrates all three `Eval()` signatures with a Repeater — `DataBinder.Eval(container, "Prop")`, shorthand `Eval("Prop")` via `@using static`, and `Eval("Prop", "{0:C}")` with format strings. Each section has live demo + code block. Section 4 ("Moving On") shows the modern `@context.Property` approach side by side.
50+
- **ViewState sample** (`Components/Pages/ControlSamples/ViewState/Index.razor`): Uses `@ref` to a Panel component to demo `ViewState.Add`/`ViewState["key"]` dictionary API. Shows a click counter and a multi-key settings form stored in ViewState, then contrasts with the modern C# field/property approach. `#pragma warning disable CS0618` suppresses the Obsolete warnings for the demo code.
51+
- **Navigation fixes applied:** NavMenu.razor Login Components reordered (Login before LoginName), DataBinder and ViewState added to Utility Features (alphabetical: DataBinder, ID Rendering, PageService, ViewState). ComponentList.razor fixed: HyperLink moved before Image in Editor Controls, ImageMap removed from Editor Controls and added to Navigation Controls (per team decision), Utility Features column added. mkdocs.yml: ImageMap removed from Editor Controls nav (already in Navigation Controls).
52+
- **Widget model reused:** DataBinder sample reuses `SharedSampleObjects.Models.Widget` with inline data (Laptop Stand, USB-C Hub, Mechanical Keyboard) for a product catalog demo.
53+
- **Build verified:** `dotnet build` passes with 0 compilation errors (Debug config). Release config has a known transient Nerdbank.GitVersioning file-copy issue unrelated to this work.

‎mkdocs.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ nav:
7474
- HiddenField: EditorControls/HiddenField.md
7575
- Image: EditorControls/Image.md
7676
- ImageButton: EditorControls/ImageButton.md
77-
- ImageMap: EditorControls/ImageMap.md
7877
- Label: EditorControls/Label.md
7978
- LinkButton: EditorControls/LinkButton.md
8079
- ListBox: EditorControls/ListBox.md

‎samples/AfterBlazorServerSide.Tests/ControlSampleTests.cs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,15 @@ public async Task LoginControl_Loads_WithoutErrors(string path)
175175
await VerifyPageLoadsWithoutErrors(path);
176176
}
177177

178+
// Utility Features
179+
[Theory]
180+
[InlineData("/ControlSamples/DataBinder")]
181+
[InlineData("/ControlSamples/ViewState")]
182+
public async Task UtilityFeature_Loads_WithoutErrors(string path)
183+
{
184+
await VerifyPageLoadsWithoutErrors(path);
185+
}
186+
178187
// Other Controls
179188
[Theory]
180189
[InlineData("/ControlSamples/AdRotator")]

‎samples/AfterBlazorServerSide.Tests/InteractiveComponentTests.cs‎

Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1448,6 +1448,106 @@ public async Task PasswordRecovery_CustomText_Applies()
14481448
}
14491449
}
14501450

1451+
[Fact]
1452+
public async Task DataBinder_Eval_RendersProductData()
1453+
{
1454+
// Arrange
1455+
var page = await _fixture.NewPageAsync();
1456+
var consoleErrors = new List<string>();
1457+
1458+
page.Console += (_, msg) =>
1459+
{
1460+
if (msg.Type == "error")
1461+
{
1462+
if (!System.Text.RegularExpressions.Regex.IsMatch(msg.Text, @"^\[\d{4}-\d{2}-\d{2}T"))
1463+
{
1464+
consoleErrors.Add(msg.Text);
1465+
}
1466+
}
1467+
};
1468+
1469+
try
1470+
{
1471+
// Act
1472+
await page.GotoAsync($"{_fixture.BaseUrl}/ControlSamples/DataBinder", new PageGotoOptions
1473+
{
1474+
WaitUntil = WaitUntilState.NetworkIdle,
1475+
Timeout = 30000
1476+
});
1477+
1478+
// Assert — Product data rendered by DataBinder.Eval in tables
1479+
var pageContent = await page.ContentAsync();
1480+
Assert.Contains("Laptop Stand", pageContent);
1481+
Assert.Contains("USB-C Hub", pageContent);
1482+
Assert.Contains("Mechanical Keyboard", pageContent);
1483+
1484+
// Assert — Table rows exist (Repeater renders <tr> items inside <tbody>)
1485+
var tableRows = await page.Locator("tbody tr").AllAsync();
1486+
Assert.True(tableRows.Count >= 3, "Expected at least 3 data rows from the Repeater");
1487+
1488+
// Assert no console errors
1489+
Assert.Empty(consoleErrors);
1490+
}
1491+
finally
1492+
{
1493+
await page.CloseAsync();
1494+
}
1495+
}
1496+
1497+
[Fact]
1498+
public async Task ViewState_Counter_IncrementsOnClick()
1499+
{
1500+
// Arrange
1501+
var page = await _fixture.NewPageAsync();
1502+
var consoleErrors = new List<string>();
1503+
1504+
page.Console += (_, msg) =>
1505+
{
1506+
if (msg.Type == "error")
1507+
{
1508+
if (!System.Text.RegularExpressions.Regex.IsMatch(msg.Text, @"^\[\d{4}-\d{2}-\d{2}T"))
1509+
{
1510+
consoleErrors.Add(msg.Text);
1511+
}
1512+
}
1513+
};
1514+
1515+
try
1516+
{
1517+
// Act — Navigate to the ViewState page
1518+
await page.GotoAsync($"{_fixture.BaseUrl}/ControlSamples/ViewState", new PageGotoOptions
1519+
{
1520+
WaitUntil = WaitUntilState.NetworkIdle,
1521+
Timeout = 30000
1522+
});
1523+
1524+
// Find the ViewState increment button (not the property-based one)
1525+
var viewStateButton = page.GetByRole(AriaRole.Button, new() { Name = "Click Me (ViewState)" });
1526+
await viewStateButton.WaitForAsync(new() { Timeout = 5000 });
1527+
1528+
// Click once — counter should go to 1
1529+
await viewStateButton.ClickAsync();
1530+
await page.WaitForTimeoutAsync(500);
1531+
1532+
var pageContent = await page.ContentAsync();
1533+
Assert.Contains("1", pageContent);
1534+
1535+
// Click again — counter should go to 2
1536+
await viewStateButton.ClickAsync();
1537+
await page.WaitForTimeoutAsync(500);
1538+
1539+
pageContent = await page.ContentAsync();
1540+
Assert.Contains("2", pageContent);
1541+
1542+
// Assert no console errors
1543+
Assert.Empty(consoleErrors);
1544+
}
1545+
finally
1546+
{
1547+
await page.CloseAsync();
1548+
}
1549+
}
1550+
14511551
[Fact]
14521552
public async Task Localize_RendersTextContent()
14531553
{

‎samples/AfterBlazorServerSide/Components/Layout/NavMenu.razor‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@
125125

126126
<TreeNode Text="ChangePassword" NavigateUrl="/ControlSamples/ChangePassword" />
127127
<TreeNode Text="CreateUserWizard" NavigateUrl="/ControlSamples/CreateUserWizard" />
128-
<TreeNode Text="LoginName" NavigateUrl="/ControlSamples/LoginName"></TreeNode>
129-
<TreeNode Text="Login" NavigateUrl="/ControlSamples/Login"></TreeNode>
128+
<TreeNode Text="Login" NavigateUrl="/ControlSamples/Login" />
129+
<TreeNode Text="LoginName" NavigateUrl="/ControlSamples/LoginName" />
130130
<TreeNode Text="LoginStatus" Expanded="false">
131131

132132
<TreeNode Text="Authenticated" NavigateUrl="/ControlSamples/LoginStatusAuthenticated"></TreeNode>
@@ -138,8 +138,10 @@
138138
</TreeNode>
139139

140140
<TreeNode Text="Utility Features">
141+
<TreeNode Text="DataBinder" NavigateUrl="/ControlSamples/DataBinder" />
141142
<TreeNode Text="ID Rendering" NavigateUrl="/ControlSamples/IDRendering" />
142-
<TreeNode Text="PageService" NavigateUrl="/UtilityFeatures/PageService"></TreeNode>
143+
<TreeNode Text="PageService" NavigateUrl="/UtilityFeatures/PageService" />
144+
<TreeNode Text="ViewState" NavigateUrl="/ControlSamples/ViewState" />
143145
</TreeNode>
144146
<TreeNode Text="Migration Guides">
145147
<TreeNode Text="MasterPages" NavigateUrl="/control-samples/masterpage"></TreeNode>

‎samples/AfterBlazorServerSide/Components/Pages/ComponentList.razor‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
<li><a href="/ControlSamples/DropDownList">DropDownList</a></li>
1111
<li><a href="/ControlSamples/FileUpload">FileUpload</a></li>
1212
<li><a href="/ControlSamples/HiddenField">HiddenField</a></li>
13-
<li><a href="/ControlSamples/Image">Image</a></li>
1413
<li><a href="/ControlSamples/HyperLink">HyperLink</a></li>
15-
<li><a href="/ControlSamples/ImageMap">ImageMap</a></li>
14+
<li><a href="/ControlSamples/Image">Image</a></li>
1615
<li><a href="/ControlSamples/LinkButton">LinkButton</a></li>
1716
<li><a href="/ControlSamples/Literal">Literal</a></li>
1817
<li><a href="/ControlSamples/Localize">Localize</a></li>
@@ -57,6 +56,8 @@
5756
<div class="col-md-3">
5857
<h3>Navigation Controls</h3>
5958
<ul>
59+
<li><a href="/ControlSamples/HyperLink">HyperLink</a></li>
60+
<li><a href="/ControlSamples/ImageMap">ImageMap</a></li>
6061
<li><a href="/ControlSamples/Menu">Menu</a></li>
6162
<li><a href="/ControlSamples/SiteMapPath">SiteMapPath</a></li>
6263
<li><a href="/ControlSamples/TreeView">TreeView</a></li>
@@ -76,4 +77,14 @@
7677
<li><a href="/ControlSamples/PasswordRecovery">PasswordRecovery</a></li>
7778
</ul>
7879
</div>
80+
81+
<div class="col-md-3">
82+
<h3>Utility Features</h3>
83+
<ul>
84+
<li><a href="/ControlSamples/DataBinder">DataBinder</a></li>
85+
<li><a href="/ControlSamples/IDRendering">ID Rendering</a></li>
86+
<li><a href="/UtilityFeatures/PageService">PageService</a></li>
87+
<li><a href="/ControlSamples/ViewState">ViewState</a></li>
88+
</ul>
89+
</div>
7990
</div>

0 commit comments

Comments
 (0)