chore: session log — BWFC010-012 usage validation analyzers

Session: 2026-03-20-usage-validation-analyzers
Requested by: Jeffrey T. Fritz

Changes:
- Added orchestration logs for Cyclops and Rogue agents (2026-03-20T12-43-10Z)
- Added session log (2026-03-20T12-43-10Z-usage-validation-analyzers.md)
- Merged 2 decisions from inbox: idempotent code fixes pattern, BWFC011 test failure bug
- Deleted processed inbox files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: csharpfritz

.squad/agents/rogue/history.md

@@ -368,3 +368,25 @@ Pattern: Roslyn analyzer tests use CSharpAnalyzerTest with stub types for WebCon
 **Key Roslyn Trivia Lesson:** When using `EmptyStatement` as a replacement anchor for TODO comments, the semicolon token MUST be on its own line — never after a `//` comment. Single-line comments consume everything until end-of-line, making any trailing tokens invisible to re-parsing.
 
 **Test stats:** 54/54 passing (BWFC001: 26, BWFC002: 6, BWFC003: 6, BWFC004: 6, BWFC005: 6, code fixes: 4).
+
+### BWFC012 Analyzer + Integration Tests (2026-03-21)
+
+**BWFC012 RunatServerAnalyzer (10 tests, all pass):** Detects leftover `runat="server"` and `runat='server'` patterns in C# string literals. Case-insensitive matching via `ToLowerInvariant()`. Registers on `SyntaxKind.StringLiteralExpression`. Code fix uses `Regex.Replace` to strip the attribute and surrounding whitespace from the string value.
+
+**Tests:** 4 positive (double-quote, single-quote, field initializer, case-insensitive), 4 negative (runat without server, variable named runat, server without runat, empty string), 2 code fix (removes double-quote variant, removes single-quote variant).
+
+**AllAnalyzersIntegrationTests (8 tests, all pass):** Cross-analyzer validation:
+- `AllAnalyzerTypes_AreDiscoverable` — reflection finds ≥8 analyzer classes in assembly
+- `AllDiagnosticIds_AreUnique` — no two analyzers share a diagnostic ID
+- `AllExpectedIds_AreRegistered` — all 8 IDs (BWFC001-005, 010-012) present
+- `AllAnalyzers_HaveUsageCategory` — every descriptor uses "Usage" category
+- `AllAnalyzers_AreEnabledByDefault` — all enabled by default
+- `ComplexWebControl_TriggersMultipleDiagnostics` — BWFC001+002+003 fire together on a single WebControl subclass
+- `KitchenSink_FiveAnalyzersFire` — 6 analyzers fire simultaneously (001+002+003+005+011+012)
+- `CleanBlazorComponent_NoDiagnostics` — properly migrated code produces zero warnings
+
+**Pre-existing failure noted:** Cyclops's `EventHandlerSignatureAnalyzerTests.CodeFix_AddsTodoComment` (BWFC011) fails — code fix output doesn't match expected. Not related to BWFC012 or integration tests.
+
+**Key patterns:** Multi-analyzer integration tests use `CompilationWithAnalyzers` directly (not `CSharpAnalyzerTest<T>`) since the standard test harness only supports single-analyzer testing. Stub types (WebControl, ViewState, Session) must be defined inline for the compilation to resolve semantic checks.
+
+**Test stats:** 88/89 passing (BWFC001: 26, BWFC002: 6, BWFC003: 6, BWFC004: 6, BWFC005: 6, BWFC010: 9, BWFC011: 7 [1 fail], BWFC012: 10, integration: 8, code fixes: 4).

.squad/decisions.md

@@ -11597,3 +11597,62 @@ Change the expression placeholder format to avoid `>`:
 - Option C: Use a regex for self-closing that is aware of quoted attribute values: `<(asp_\w+)((?:\s+\w+\s*=\s*(?:"[^"]*"|'[^']*'))*)\s*/>`
 
 **Assigned to:** Cyclops (parser owner)
+
+### 2026-07-25: Idempotent Code Fixes for Advisory Analyzers
+
+**Author:** Cyclops  
+**Date:** 2026-07-25  
+**Context:** BWFC010/BWFC011 implementation
+
+## Decision
+
+When a Roslyn code fix adds a TODO comment but does NOT remove the underlying diagnostic (advisory/Info-severity analyzers), the code fix **must be idempotent** — check for existing TODO in leading trivia before adding.
+
+## Rationale
+
+The Roslyn test framework (and IDE) applies code fixes iteratively until convergence. If a fix adds a comment but the diagnostic persists, the fix runs again. Without an idempotency guard, duplicates accumulate.
+
+## Pattern
+
+`csharp
+// In code fix provider, before adding TODO:
+foreach (var trivia in node.GetLeadingTrivia())
+{
+    if (trivia.IsKind(SyntaxKind.SingleLineCommentTrivia) &&
+        trivia.ToString().Contains("TODO: <unique marker>"))
+        return document; // Already applied
+}
+`
+
+Test configuration for persistent diagnostics:
+`csharp
+FixedState = { ExpectedDiagnostics = { ... } },
+NumberOfIncrementalIterations = 2,
+NumberOfFixAllIterations = 2,
+`
+
+## Scope
+
+Applies to all future BWFC analyzers at Info severity where the code fix doesn't resolve the diagnostic.
+
+### 2026-03-21: BWFC011 Code Fix Test Failure
+
+**Author:** Rogue (QA Analyst)  
+**Date:** 2026-03-21  
+**Branch:** experiment/aspx-middleware  
+**Status:** Bug — needs Cyclops fix
+
+## Context
+
+While running the full analyzer test suite (89 tests), discovered that EventHandlerSignatureAnalyzerTests.CodeFix_AddsTodoComment fails with a content mismatch. The BWFC011 analyzer itself works correctly (all 6 non-code-fix tests pass), but the code fix provider produces output that doesn't match the expected fixed source.
+
+## Impact
+
+- 88/89 tests pass; only this one code fix test fails
+- The analyzer detection is fine — only the automated fix is broken
+- Not blocking BWFC012 or integration test work
+
+## Recommendation
+
+Cyclops should check the EventHandlerSignatureCodeFixProvider output against the expected ixedSource in the test. Likely a trivia/whitespace issue similar to the BWFC004/005 fixes that needed EndOfLine trivia corrections.
+

.squad/decisions/inbox/cyclops-idempotent-advisory-codefixes.md

@@ -0,0 +1,32 @@
+# Orchestration: Cyclops (Component Dev)
+
+**Spawn Time:** 2026-03-20T12:43:10Z  
+**Mode:** background  
+**Status:** SUCCESS
+
+## Task
+Build BWFC010 (required attributes) + BWFC011 (event handler signatures) analyzers with code fixes and tests.
+
+## Outcome
+
+- **BWFC010 Analyzer:** Built. Part of earlier commit.
+- **BWFC011 Analyzer:** Built. EventHandlerSignatureAnalyzer + EventHandlerSignatureCodeFixProvider.
+  - 6 analyzer tests ✓
+  - 1 code fix test ⚠️ (failing on output mismatch — see Rogue's decision in inbox)
+- **Total Test Count:** 17 tests across both analyzers
+- **Commits:**
+  - b2432e26 (BWFC010 as part of earlier work)
+  - 928694b5 (BWFC011 implementation)
+  - 99349b0a (history update)
+
+## Decisions Filed
+
+- **cyclops-idempotent-advisory-codefixes.md:** Pattern for preventing duplicate TODO comments in Info-severity analyzer code fixes when diagnostics persist.
+
+## Known Issues
+
+- BWFC011 code fix test failure flagged by Rogue — output content mismatch. Likely trivia/whitespace issue in EventHandlerSignatureCodeFixProvider.
+
+## Next
+
+Rogue's BWFC012 work and integration tests can proceed in parallel. Code fix failure in BWFC011 is non-blocking.

.squad/orchestration-log/2026-03-20T12-43-10Z-cyclops.md

@@ -0,0 +1,31 @@
+# Orchestration: Rogue (QA Analyst)
+
+**Spawn Time:** 2026-03-20T12:43:10Z  
+**Mode:** background  
+**Status:** SUCCESS
+
+## Task
+Build BWFC012 (runat=server) analyzer + cross-analyzer integration tests.
+
+## Outcome
+
+- **BWFC012 Analyzer:** Built. RequiredRunatAttributeAnalyzer + RequiredRunatAttributeCodeFixProvider.
+- **Test Count:**
+  - 10 unit tests (BWFC012-specific)
+  - 8 integration tests (cross-analyzer: BWFC010, BWFC011, BWFC012)
+- **Total:** 18 tests, all passing
+- **Commits:**
+  - baf3e40f (BWFC012 implementation)
+  - b2432e26 (integration tests)
+
+## Decisions Filed
+
+- **rogue-bwfc011-codefix-failure.md:** Bug report on BWFC011 code fix test failure (88/89 tests pass). Output mismatch in EventHandlerSignatureCodeFixProvider — likely trivia/whitespace issue.
+
+## Known Issues
+
+- BWFC011 code fix test failure discovered during integration test runs. Flagged for Cyclops. Not blocking BWFC012 or integration work.
+
+## Next
+
+All analyzer pairs (BWFC010, BWFC011, BWFC012) integrated and tested. Ready for next phase.