docs(ai-team): log benchmark fixes session and merge decisions

Session: 2026-03-04-benchmark-fixes
Requested by: Jeffrey T. Fritz

Changes:
- Logged session to .ai-team/log/2026-03-04-benchmark-fixes.md
- Merged 6 decision files from inbox into decisions.md
- Consolidated overlapping toolkit-location decisions
- Normalized inbox decision block formats (# Decision -> ###)
- Propagated cross-agent updates to 6 agent history files
- Deleted merged inbox files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: csharpfritz

.ai-team/agents/beast/history.md

@@ -142,3 +142,7 @@
   - Added "Migration Tests" nav section to `mkdocs.yml` after the Migration section.
   - **Convention established:** Each migration test run gets its own subfolder named `{app}-{YYYY-MM-DD}` containing `report.md` and an `images/` directory. The README.md index links to all runs.
 
+
+ Team update (2026-03-04): Migration test reports go in docs/migration-tests/  directed by Jeffrey T. Fritz
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz
+ Team update (2026-03-04): Layer 1 benchmark baseline established by Cyclops  data at docs/migration-tests/wingtiptoys-2026-03-04/  decided by Cyclops

.ai-team/agents/colossus/history.md

@@ -82,3 +82,5 @@ Added 5 smoke tests (Timer, UpdatePanel, UpdateProgress, ScriptManager, Substitu
 
  Team update (2026-03-03): ListView CRUD test conventions established  43 tests, event ordering via List<string>, cancellation assertions, bUnit double-render handling  decided by Rogue
 
+
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz

.ai-team/agents/cyclops/history.md

@@ -120,3 +120,7 @@ Team update (2026-02-28): GetCssClassOrNull() uses IsNullOrEmpty not IsNullOrWhi
 - **Architecture:** SQLite, scoped CartStateService/CheckoutStateService, MockPayPalService, ASP.NET Core Identity with canEdit role.
 - **Pattern:** Layer 2+3 takes ~9 min with Copilot vs estimated 4-8 hours manually. The migration skills provide reliable translation rules. Having a reference implementation (AfterWingtipToys) to validate against accelerates decisions significantly.
 
+
+ Team update (2026-03-04): Migration test reports go in docs/migration-tests/  directed by Jeffrey T. Fritz
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz
+ Team update (2026-03-04): migration-toolkit/ is the distribution package for external users; .github/skills/ is internal only  decided by Forge, Jeffrey T. Fritz

.ai-team/agents/forge/history.md

@@ -138,3 +138,6 @@ Team updates (2026-03-02): Unified release (PR #408), project reframed as migrat
 
 **Key learning:** Distributable assets (things end-users copy to their own projects) live in `migration-toolkit/`. Internal project skills (things that help contributors work on THIS repo) live in `.github/skills/`. Clean separation prevents confusion about what ships to customers vs what's internal tooling.
 Team updates (2026-03-02-03): Unified release (PR #408), project reframed as migration system (Jeff), ModelErrorMessage docs (Beast), themes last directive (Jeff Fritz).
+
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz
+ Team update (2026-03-04): Layer 1 benchmark: 14 unconverted expressions + 4 Register directives define Layer 2 scope  decided by Cyclops

.ai-team/agents/jubilee/history.md

@@ -90,3 +90,5 @@
 
  Team update (2026-03-03): WingtipToys 7-phase feature schedule established  26 work items, critical path through Data Foundation  Product Browsing  Shopping Cart  Checkout  Polish  decided by Forge
 
+
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz

.ai-team/agents/rogue/history.md

@@ -92,3 +92,5 @@ Key test patterns: (1) CSS class selectors for template switching. (2) cut.Invok
 Key file paths: `src/BlazorWebFormsComponents.Test/ListView/EditTemplateTests.razor`, `src/BlazorWebFormsComponents.Test/FormView/RenderOuterTable.razor`, `src/BlazorWebFormsComponents.Test/ListView/ListViewCrudEventTests.razor`.
 
 Team updates (2026-03-02-03): Skins roadmap (Forge), M22 planned (Forge), project reframed as migration system (Jeff), ModelErrorMessage spec (Forge), themes last directive (Jeff Fritz), IOrderedDictionary on ListView EventArgs (Cyclops), WingtipToys 7-phase schedule (Forge).
+
+ Team update (2026-03-04): PRs must target upstream FritzAndFriends repo, not origin fork  directed by Jeffrey T. Fritz

.ai-team/decisions.md

@@ -5464,7 +5464,6 @@ Nothing is rendered (the component returns `null` / empty fragment). This matche
 **What:** Created `docs/ValidationControls/ModelErrorMessage.md` for the new ModelErrorMessage validation component. Added to `mkdocs.yml` nav (alphabetical within Validation Controls). Updated `status.md` — Validation Controls count from 7→8, total from 51→52.
 **Why:** M21 wrap-up deliverable. ModelErrorMessage is a new validation component that displays model state errors for a specific key, matching `<asp:ModelErrorMessage>`. Documentation covers: features (ModelStateKey, AssociatedControlID, SetFocusOnError, CssClass), Web Forms→Blazor syntax comparison, EditContext/ValidationMessageStore code-behind migration pattern, and HTML output. Follows established validation control documentation pattern.
 
-
 ### ModelErrorMessage integration test coverage added
 
 **By:** Colossus
@@ -5476,13 +5475,11 @@ Nothing is rendered (the component returns `null` / empty fragment). This matche
 **What:** PRs should always target the upstream repository (FritzAndFriends/BlazorWebFormsComponents), not the fork (csharpfritz/BlazorWebFormsComponents). Use cross-fork PR format: head = csharpfritz:{branch}, base = dev on FritzAndFriends.
 **Why:** User request  captured for team memory
 
-
 ### 2026-03-02: WingtipToys Migration Analysis Results
 **By:** Forge
 **What:** Comprehensive page-by-page comparison of all 33 WingtipToys source files (.aspx/.ascx/.master) against their migrated Blazor equivalents (.razor). Layer 1 (bwfc-migrate.ps1) successfully handled ~70% of markup transforms: 147+ tag prefix removals, 165+ runat="server" removals, Content wrapper stripping, @page directive generation, ~35 expression conversions, ItemType→TItem conversion, comment syntax, and URL prefix conversion. 18 data-binding expressions remain unconverted (<%#: syntax), 8 SelectMethod attributes need Items/DataItem replacement, 3 GetRouteUrl calls need route interpolation, 3 user-control tag prefixes (uc:, friendlyUrls:) need stripping. BWFC has 100% control coverage for WingtipToys (28/29 controls exist; ContentPlaceHolder maps to @Body). 4 pages are fully ready, 21 need Layer 2 skill work, 8 need Layer 3 architecture (Identity, EF, Session, PayPal). Estimated total migration effort: 18-26 hours across all three layers.
 **Why:** Jeff needs to understand the effectiveness of the three-layer migration pipeline (Script → Skill → Agent) before the M22 Copilot-Led Migration Showcase. This analysis validates that Layer 1 handles high-volume mechanical transforms effectively, Layer 2 covers structural patterns via the Copilot Skill, and Layer 3 architectural decisions are limited to auth/data/session/integrations. The pipeline is proven: a developer using all three layers could migrate WingtipToys to a running Blazor app in under a day. Key actionable findings: (1) Layer 1 should add regex for <%#: Item.X %> → @context.X conversion, (2) Layer 1 should strip user-control tag prefixes during Register directive removal, (3) Account pages should use scaffolded Identity UI rather than migrating OWIN code-behind, (4) SelectMethod→Items is the #1 most common Layer 2 transform.
 
-
 ### 2026-03-02: Original WingtipToys Build & Run Configuration
 **By:** Cyclops
 **Date:** 2026-03-02
@@ -5543,21 +5540,119 @@ Jeff reframed the project as a "migration acceleration system." The toolkit is t
 - **Jubilee:** The QUICKSTART references `samples/AfterWingtipToys/` as reference implementation.
 - **All:** Three remaining docs (ARCHITECTURE-GUIDE.md, FAQ.md, CASE-STUDY.md) can be authored when prioritized.
 
-
 ### 2026-03-02: User directive  Themes implementation last
 **By:** Jeff Fritz (via Copilot)
 **What:** Themes (#369, M11 Full Skins & Themes) should come LAST in priority. ListView CRUD events first, then WingtipToys remaining features, then themes.
 **Why:** User request  captured for team memory
+
 ### 2026-03-04: ListView EventArgs use IOrderedDictionary for Web Forms parity
 **By:** Cyclops
 **What:** Added IOrderedDictionary properties to ListViewInsertEventArgs (Values), ListViewUpdateEventArgs (Keys, OldValues, NewValues), and ListViewDeleteEventArgs (Keys, Values), initialized to empty OrderedDictionary in constructors. Matches FormViewUpdateEventArgs/FormViewDeleteEventArgs pattern. Also added TotalRowCount to ListViewPagePropertiesChangingEventArgs.
 **Why:** ListView CRUD EventArgs were missing dictionary-based properties (Keys, Values, OldValues, NewValues) that Web Forms originals expose. Consumers can now populate these in event handlers, matching the Web Forms programming model. No breaking changes  all new properties are additive. This supersedes the earlier M7 decision to avoid OrderedDictionary on ListView; full parity is now required.
+
 ### 2026-03-02: ListView CRUD Event Test Conventions
 **By:** Rogue
 **What:** 43 bUnit tests for all 16 ListView CRUD events. Conventions: (1) event ordering via List<string> with ShouldBe assertions, (2) cancellation tests set Cancel=true and assert -ed handler stays null, (3) DataBound/ItemDataBound use ShouldBeGreaterThanOrEqualTo for bUnit double-render, (4) ItemCreated needs async test with InvokeAsync, (5) CancelMode detection: InsertItemPosition!=None && EditIndex<0 = CancelingInsert.
 **Why:** Proactive tests written ahead of implementation for immediate CI validation. Patterns should be followed for any future ListView event tests.
+
 ### 2026-03-03: WingtipToys remaining feature schedule
 **By:** Forge
 **What:** 7-phase prioritized schedule for WingtipToys migration: (1) Data Foundation  EF Core, models, CartStateService, BoundField fix; (2) Product Browsing  ProductList/Details data binding; (3) Shopping Cart  AddToCart, ShoppingCart wiring; (4) Checkout Flow  CheckoutStateService, mock PayPal, checkout pages; (5) Admin  add/remove product, FileUpload, validation; (6) Identity & Auth  ASP.NET Core Identity, login/register, authorization; (7) Polish  CSS verification, smoke test. 26 work items total (10S + 13M + 2L). Critical path: Phase 1  2  3  4  7. Max parallelism after Phase 1.
 **Why:** Jeff requested prioritization of remaining WingtipToys features. Gap is almost entirely code-behind logic  markup/BWFC migration is done. ~10-14 working days with parallel execution.
 
+### 2026-03-04: User directive — migration test reports location
+**By:** Jeffrey T. Fritz (via Copilot)
+**What:** Migration test runs with screenshots and measurements go in `docs/migration-tests/` with a subfolder per run containing a markdown report and supporting images. This is the standard location for all migration benchmarking.
+**Why:** User request — establishes a repeatable pattern for tracking migration test results over time.
+
+### 2026-03-03: User directive — PRs target upstream
+**By:** Jeffrey T. Fritz (via Copilot)
+**What:** Pull requests should be created on the upstream repository (FritzAndFriends/BlazorWebFormsComponents), not the origin fork (csharpfritz/BlazorWebFormsComponents). Use `gh pr create --repo FritzAndFriends/BlazorWebFormsComponents` or equivalent.
+**Why:** User request — captured for team memory. The fork is for pushing branches; PRs belong on the org repo.
+
+### 2026-03-03: User directive — distributable assets location
+**By:** Jeffrey T. Fritz (via Copilot)
+**What:** Distributable migration skills and PowerShell scripts must NOT live in `.github/skills/`. They belong in a `migration-toolkit/` folder that contains everything needed for external projects to consume. The `.github/skills/` folder is reserved for internal project skills only. Move the 3 BWFC migration skills and the PowerShell scripts (bwfc-scan.ps1, bwfc-migrate.ps1) into migration-toolkit/.
+**Why:** User request — the toolkit is a product to distribute, not internal project configuration.
+
+
+### 2026-03-04: Layer 1 Benchmark Baseline Established
+**By:** Cyclops
+**Status:** Informational
+
+## What
+
+Ran bwfc-scan.ps1 and bwfc-migrate.ps1 against WingtipToys to establish Layer 1 benchmark baselines. Results saved to `docs/migration-tests/wingtiptoys-2026-03-04/`.
+
+## Key Numbers
+
+- **Scan:** 0.9s, 32 files, 230 controls, 100% BWFC coverage
+- **Migrate:** 2.4s, 276 transforms, 33 .razor files generated, 18 manual items flagged
+- **Build:** 338 errors (expected — code-behind not yet transformed)
+
+## Observations for the Team
+
+1. **bwfc-migrate.ps1 scaffold targets net8.0** — should be updated to detect repo TFM or default to net10.0. Also generates NuGet PackageReference instead of ProjectReference for local dev.
+2. **14 unconverted code blocks** are complex data binding expressions (`<%#: String.Format(...)%>`, `<%#: GetRouteUrl(...)%>`). These should be targeted by Layer 2 Copilot skill transforms.
+3. **Register directives** are stripped but the component tag prefixes (`uc:`, `friendlyUrls:`) remain in markup as bare tags. Layer 2 needs to resolve these to Blazor component references.
+4. **All 338 build errors are in code-behind** — markup transforms are clean. This validates the Layer 1 / Layer 2 boundary.
+
+## Impact
+
+- Beast: benchmark data is ready at `docs/migration-tests/wingtiptoys-2026-03-04/layer1-results.md`
+- Forge: the 14 unconverted expressions + 4 Register directives define Layer 2 scope for markup
+- All: `samples/FreshWingtipToys/` is the new fresh migration target — do NOT touch `samples/AfterWingtipToys/`
+
+
+### 2026-03-04: Layer 2+3 Benchmark Approach
+**By:** Cyclops
+**Status:** Implemented
+
+## Context
+
+Layer 1 scripts produced FreshWingtipToys with 33 .razor files and 338 build errors. The task was to complete the migration using the BWFC migration skills and capture timing.
+
+## Decisions
+
+1. **Account pages copied from AfterWingtipToys reference.** Identity migration is complex (15 pages with UserManager, SignInManager, role checks) and boilerplate. In a real migration, these would be generated from ASP.NET Core Identity scaffolding. Time saved: ~15-20 min.
+
+2. **MockPayPalService instead of real NVPAPICaller.** The original used PayPal NVP API (deprecated). Modern approach would be PayPal REST API v2 with HttpClient. Mock is sufficient for the benchmark.
+
+3. **ProductDetails simplified from FormView to direct rendering.** The original used FormView with SelectMethod for a single product. Direct property rendering is simpler and more idiomatic Blazor.
+
+4. **SQLite for development database.** Matches AfterWingtipToys. One-line change to switch to SQL Server for production.
+
+5. **Site.Mobile.razor and ViewSwitcher.razor stubbed.** Blazor uses responsive CSS, not separate mobile layouts.
+
+## Impact
+
+- Total Layer 2+3 migration: **~9.4 minutes** with Copilot
+- 81 files changed, 1540 insertions, 2807 deletions
+- Clean build: 0 errors, 0 warnings
+- The migration skills (bwfc-migration, bwfc-data-migration) provided accurate translation rules for every pattern encountered
+
+
+### 2026-03-03: Restructure migration-toolkit as self-contained distribution package (consolidated)
+**By:** Forge, Jeffrey T. Fritz
+**Status:** Implemented
+
+## Context
+
+Distributable migration skills (bwfc-migration, bwfc-identity-migration, bwfc-data-migration) were located in `.github/skills/` alongside internal project skills (webforms-migration, documentation, component-development, bunit-test-migration, aspire). This mixed distributable assets with internal tooling, making it unclear what end-users should copy to their own projects.
+
+## Decision
+
+Move all distributable migration assets into `migration-toolkit/` as a self-contained distribution package:
+
+- **`migration-toolkit/skills/`** — 3 Copilot skill files that users copy into their project's `.github/skills/`
+- **`migration-toolkit/scripts/`** — 2 PowerShell scripts (bwfc-scan.ps1, bwfc-migrate.ps1) that users copy to their project root
+- **`.github/skills/`** — retains only internal project skills used by contributors to this repo
+
+Scripts are copied (not moved) because `scripts/` originals are still used by the project internally.
+
+## Consequences
+
+- `migration-toolkit/` is now the single artifact a user downloads/copies to migrate their Web Forms app
+- No confusion about which skills are for end-users vs which are internal
+- README.md updated with explicit usage instructions and NuGet link
+- Relative links in README.md updated from `../scripts/` and `../.github/skills/` to local `scripts/` and `skills/` paths