refactor: replace empty() with explicit checks, fix null safety

- Replace all empty() calls with explicit === '' / !== null checks
- Add is_array() guard in ConfigHelper::execConfig() traversal
- Handle preg_replace() null return in helpers
- Fix setCallbackContentMessage() using isset() instead of truthy check
- Make ConfigHelper::config readonly and private
- Add return type to tgn_view()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: tanhongit

common/helpers.php

@@ -10,7 +10,7 @@
      *
      * @return string|null
      */
-    function tgn_singularity(string $word): string|null
+    function tgn_singularity(string $word): ?string
     {
         static $singular_rules = [
             '/(quiz)zes$/i' => '$1',
@@ -56,7 +56,7 @@ function tgn_singularity(string $word): string|null
      */
     function tgn_snake_case(string $string): string
     {
-        $string = preg_replace('/\s+/', '_', $string);
+        $string = preg_replace('/\s+/', '_', $string) ?? $string;
 
         return strtolower($string);
     }
@@ -100,7 +100,7 @@ function tgn_convert_event_name(string $event): string
      */
     function tgn_convert_action_name(string $action): string
     {
-        return strtolower(preg_replace('/(?<!^)[A-Z]/', '_$0', $action));
+        return strtolower(preg_replace('/(?<!^)[A-Z]/', '_$0', $action) ?? $action);
     }
 }
 
@@ -128,28 +128,26 @@ function config(string $string): mixed
          *
          * @return null|string
          */
-        function view(string $partialPath, array $data = []): null|string
+        function view(string $partialPath, array $data = []): ?string
         {
             $content = (new ConfigHelper())->getTemplateData(
                 $partialPath,
                 $data
             );
 
-            return $content ?: null;
+            return $content !== '' ? $content : null;
         }
     }
 }
 
 if (!function_exists('tgn_view')) {
     /**
-     * Get view template
+     * Get view template from the correct source (Laravel Blade or standalone PHP).
      *
-     * @param string $partialPath
-     * @param array $data
-     *
-     * @noinspection PhpMissingReturnTypeInspection
+     * @param string $partialPath Dot-notation template path
+     * @param array<string, mixed> $data Variables to pass to the template
      */
-    function tgn_view(string $partialPath, array $data = [])
+    function tgn_view(string $partialPath, array $data = []): mixed
     {
         if (class_exists('Illuminate\Foundation\Application')) {
             $partialPath = config('telegram-git-notifier.view.namespace') . '::' . $partialPath;

src/Bot.php

@@ -61,7 +61,7 @@ public function __construct(
 
     public function validateSettingFile(): void
     {
-        if (empty($this->setting->getSettingFile())) {
+        if ($this->setting->getSettingFile() === '') {
             throw ConfigFileException::settingFile($this->setting->getSettingFile());
         }
     }

src/Helpers/ConfigHelper.php

@@ -11,7 +11,7 @@ final class ConfigHelper
     /**
      * @var array<string, mixed>
      */
-    public array $config;
+    private readonly array $config;
 
     public function __construct()
     {
@@ -27,7 +27,7 @@ public function execConfig(string $string): mixed
         $result = $this->config;
 
         foreach ($keys as $key) {
-            if (!isset($result[$key])) {
+            if (!is_array($result) || !array_key_exists($key, $result)) {
                 return '';
             }
 

src/Models/Event.php

@@ -64,7 +64,7 @@ public function reloadEventConfig(): void
      */
     public function updateEvent(string $event, ?string $action): void
     {
-        if (!empty($action)) {
+        if ($action !== null && $action !== '') {
             $this->eventConfig[$event][$action]
                 = !$this->eventConfig[$event][$action];
         } else {
@@ -82,15 +82,15 @@ public function getPlatformEnum(): Platform
 
     private function loadFromFile(): void
     {
-        if (empty($this->platformFile) || !file_exists($this->platformFile)) {
+        if ($this->platformFile === '' || !file_exists($this->platformFile)) {
             $this->eventConfig = [];
 
             return;
         }
 
         $json = file_get_contents($this->platformFile);
 
-        if (!empty($json)) {
+        if ($json !== false && $json !== '') {
             $this->eventConfig = json_decode($json, true) ?? [];
         }
 

src/Models/Setting.php

@@ -53,13 +53,13 @@ public function reloadSettings(): void
 
     public function isAllEventsNotification(): bool
     {
-        return !empty($this->settings)
+        return $this->settings !== []
             && ($this->settings[SettingConstant::T_ALL_EVENTS_NOTIFICATION] ?? false) === true;
     }
 
     public function isNotified(): bool
     {
-        return !empty($this->settings)
+        return $this->settings !== []
             && ($this->settings[SettingConstant::T_IS_NOTIFIED] ?? false) === true;
     }
 
@@ -98,15 +98,15 @@ public function updateSetting(
 
     private function loadFromFile(): void
     {
-        if (empty($this->settingFile) || !file_exists($this->settingFile)) {
+        if ($this->settingFile === '' || !file_exists($this->settingFile)) {
             $this->settings = [];
 
             return;
         }
 
         $json = file_get_contents($this->settingFile);
 
-        if (!empty($json)) {
+        if ($json !== false && $json !== '') {
             $this->settings = json_decode($json, true) ?? [];
         }
 

src/Notifier.php

@@ -55,7 +55,7 @@ public function parseNotifyChatIds(?string $chatIds = null): array
     {
         $raw = $chatIds ?? config('telegram-git-notifier.bot.notify_chat_ids');
 
-        if (empty($raw)) {
+        if ($raw === null || $raw === '') {
             return [];
         }
 

src/Objects/Validator.php

@@ -53,7 +53,7 @@ public function isAccessEvent(
         $eventConfig = $this->event->getEventConfig()[tgn_convert_event_name($event)] ?? false;
         $action = $this->getActionOfEvent($payload);
 
-        if (!empty($action) && isset($eventConfig[$action])) {
+        if ($action !== '' && isset($eventConfig[$action])) {
             $eventConfig = $eventConfig[$action];
         }
 

src/Structures/App.php

@@ -31,14 +31,14 @@ private function createTelegramBaseContent(): array
 
     public function sendMessage(?string $message = '', array $options = []): void
     {
-        if (empty($message)) {
+        if ($message === null || $message === '') {
             throw MessageIsEmptyException::create();
         }
 
         $content = $this->createTelegramBaseContent();
         $content['text'] = $message;
 
-        if (!empty($options['reply_markup'])) {
+        if (isset($options['reply_markup'])) {
             $content['reply_markup'] = $this->telegram->buildInlineKeyBoard(
                 $options['reply_markup']
             );
@@ -52,7 +52,7 @@ public function sendMessage(?string $message = '', array $options = []): void
 
     public function sendPhoto(string $photo = '', array $options = []): void
     {
-        if (empty($photo)) {
+        if ($photo === '') {
             throw EntryNotFoundException::fileNotFound();
         }
 
@@ -66,7 +66,7 @@ public function sendPhoto(string $photo = '', array $options = []): void
 
     public function answerCallbackQuery(?string $text = null, array $options = []): void
     {
-        if (empty($text)) {
+        if ($text === null || $text === '') {
             throw MessageIsEmptyException::create();
         }
 
@@ -122,7 +122,7 @@ public function setCallbackContentMessage(array $options = []): array
             'parse_mode' => 'HTML',
         ];
 
-        $content['reply_markup'] = $options['reply_markup']
+        $content['reply_markup'] = isset($options['reply_markup'])
             ? $this->telegram->buildInlineKeyBoard($options['reply_markup'])
             : null;
 

src/Structures/Notification.php

@@ -91,7 +91,7 @@ private function setMessage(string $typeEvent): void
     #[\NoDiscard('The return value indicates whether the notification was sent successfully')]
     public function sendNotify(?string $message = null, array $options = []): bool
     {
-        if (!empty($message)) {
+        if ($message !== null && $message !== '') {
             $this->message = $message;
         }
 

src/Trait/ActionEventTrait.php

@@ -11,7 +11,7 @@ public function getActionOfEvent(object $payload): string
             ?? $payload->object_attributes?->noteable_type
             ?? '';
 
-        if (!empty($action)) {
+        if ($action !== '') {
             return tgn_convert_action_name($action);
         }