Skip to content

Add mixed periodicity to MATLAB interpolators and implements interpolators in C++#318

Merged
Tony-Drummond merged 27 commits intocsrc-sdsu:mainfrom
bewagner1:bpw/interpol
Apr 27, 2026
Merged

Add mixed periodicity to MATLAB interpolators and implements interpolators in C++#318
Tony-Drummond merged 27 commits intocsrc-sdsu:mainfrom
bewagner1:bpw/interpol

Conversation

@bewagner1
Copy link
Copy Markdown
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

This PR adds mixed periodicity capability to the MATLAB interpolators and implements the MATLAB interpolators in C++

Related Issues & Documents

Added/updated tests?

  • Yes
  • No, and this is why: I don't know how best to check
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

Not that I can think of

[optional] What gif best describes this PR or how it makes you feel?

@jbrzensk jbrzensk changed the title Bpw/interpol Add mixed periodicity to MATLAB interpolators and implements interpolators in C++ Apr 9, 2026
@jbrzensk jbrzensk assigned mdumett and unassigned mdumett Apr 9, 2026
@jbrzensk jbrzensk added Enhancement New feature or request C++ labels Apr 16, 2026
@jbrzensk
Copy link
Copy Markdown
Collaborator

@mdumett, there are a lot of changes in this, and we need your eyes on this, especially the MATLAB implementation.

Copy link
Copy Markdown
Collaborator

@mdumett mdumett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test_interpol.m several csv files are read. Are those files included in this PR?

@bewagner1
Copy link
Copy Markdown
Collaborator Author

The files get created by test_interpol.cpp. It makes all of the non periodic and periodic operators (but not any mixed periodic operators) in cpp and then test_interpol.m reads them in and compares them to their matlab equivalents. Mostly just a sanity check that I left in. test_interpol.sh runs the cpp executable and then the matlab script and then removes all of the .csv files. My idea was to remove the scripts before merge b/c they aren't actually testing the operators, just comparing implementations.

@Tony-Drummond
Copy link
Copy Markdown
Collaborator

Tony-Drummond commented Apr 26, 2026

@bewagner1, since you are no longer submitting test_interpol.cpp, can you remove it from the list of source files in the CMakefile, thanks! At a later time, we will need to recreate your tests or add new tests for C++ interpolators. Thanks for this contribution!

@Tony-Drummond Tony-Drummond merged commit 3c4b641 into csrc-sdsu:main Apr 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixed periodicity MATLAB interpolators and mimetic C++ interpolators

4 participants