Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
@bewagner1 The curl operator seems wrong, and will be a point of contention for many. I suggest removing it (also it doesn't have a test) to speed up the approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Implementation of the 2-D operators
div,grad,curl, andlapin julia as well as their periodic, mixed periodicity, and non uniform variants.Related Issues & Documents
QA Instructions, Screenshots, Recordings
Compare relevant code and examples to MATLAB implementaiton
Added/updated tests?
have not been included
Nullity tests for all operators
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
None that I can think of
[optional] What gif best describes this PR or how it makes you feel?