Interpolators for Julia Operators#332
Conversation
|
Hi @jlbaranda, thank you for your contribution! As of now, your PR is adding 15 files, 12 of which are in MATLAB and 3 in Julia. This was probably a git mistake. Please remove the MATLAB files. If you need any assistance please let me know. Thanks |
|
Hey @valeriabarra, I have removed the 12 MATLAB files from the Pull Request, I greatly appreciate it your prompt response. I'll keep working on the operator, and let you know if any questions arise. Thank you!! |
|
|
||
| # Initial Condition | ||
| q = 2 * π .* grid | ||
| println(typeof(q)) |
There was a problem hiding this comment.
Hi @jlbaranda , if this println statement was placed here for debugging purposes, please remove it. It is not present in the MATLAB counterpart. Thank you
| D[end, end-1] = -1/(2*dx); | ||
|
|
||
| #Premultiply out of the time loop (since it does not change) | ||
| D = -a*dt*2*D*I; |
There was a problem hiding this comment.
Why is the 2 in the RHS needed?
There was a problem hiding this comment.
Oh, I think I have gathered from the comment below that this is using the leapfrog scheme. We should document this earlier, near the top of the file, not just in a comment near the plotting routine. Thank you!
|
Hi @jlbaranda , looking at your commit history in this branch, it appears you have possibly created your branch from @jbrzensk 's branch for the M693B tutorial. Please make sure that you always base your development branch from the latest |
…nd Plots from being read
jlbaranda
force-pushed
the
interpolator_branch
branch
from
d8f63fe to
a36dbc1
Compare
|
Closing this as superseded by #340 |
3 participants
What type of PR is this? (check all applicable)
Description
I am implementing the Interpol.m operator into Julia, creating test cases and showing two examples from the MATLAB implemented examples namely the hyperbolic1D.m and burgers1d.m.
Related Issues & Documents
QA Instructions, Screenshots, Recordings
I have added to file hyperbolic1D.jl that is currently a work in progress on mole/julia/MOLE.jl/examples/
I have added interpol.m that still needs test cases on mole/julia/MOLE.jl/src/Operators and included it onto the Operators.jl file
Added/updated tests?
_We encourage you to test all code included with MOLE, including examples.
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?