Skip to content

ci: enable strict golangci-lint#781

Closed
cssbruno wants to merge 1 commit into
mainfrom
codex/strict-golangci-lint
Closed

ci: enable strict golangci-lint#781
cssbruno wants to merge 1 commit into
mainfrom
codex/strict-golangci-lint

Conversation

@cssbruno

@cssbruno cssbruno commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds a strict golangci-lint v2.12.2 configuration, pinned local runner, and GitHub Actions lint workflow.
  • Fixes the findings surfaced by the enabled linters without adding a baseline or exclude list.
  • Removes unused internal helpers where lint proved they were dead code.
  • Updates CI documentation for the new lint gate.

Issue Closure

Related: lint gate hardening; no issue auto-close.

Verification

  • I ran the relevant tests, lint, and build commands.
  • I ran scripts/test-go-modules.sh when Go code or compiler behavior changed.
  • I ran go build ./cmd/gowdk when CLI, compiler, runtime, addon, or release behavior changed.
  • I ran node --check editors/vscode/extension.js when editor files changed.
  • I updated docs for behavior, setup, or architecture changes.
  • I added or updated tests for changed behavior.
  • I considered security-sensitive surfaces such as auth, CSRF, redirects, request-time handlers, logs, diagnostics, embedded assets, editor commands, WASM, contracts, and realtime behavior.

Commands run:

  • scripts/check-golangci-lint.sh -> 0 issues.
  • go test ./internal/publicapi -count=1
  • go test ./internal/gowdkcmd -run 'TestBuildCommandProductionScansFinalArtifactsForSecrets|TestBuildCommandProductionBlocksInsecureAuditFindings|TestComputeAuditDiffClassifiesIntroducedResolvedUnchanged' -count=1
  • go build ./cmd/gowdk
  • git diff --check

Known gap: full go test ./... was attempted earlier, but the existing nested internal/gowdkcmd integration tests ran excessively long. This PR is validated with the lint gate and focused tests for the touched late fixes.

LLM Assistance

  • LLM session summary: Codex added the strict lint config and runner, fixed lint findings across the repository, rebased the work onto current main, resolved conflicts, and opened this draft PR.
  • Human-reviewed assumptions: no golangci baseline or exclude list should be used; dead unused helpers can be deleted when no call sites remain.
  • Follow-up work: run the full repository/module test suite in CI or an environment where the long internal/gowdkcmd integration tests can complete.

@github-actions github-actions Bot added compiler Compiler internals, pipeline, and generated metadata parser .gwdk parser and syntax handling IR Internal compiler IR and phase handoffs generated Go Generated Go source and adapter output runtime GOWDK Runtime packages and server behavior SSR Request-time page rendering client Generated browser enhancement runtime WASM Go js/wasm artifacts and islands security Security hardening and security-sensitive behavior ops Operations, release, deployment, and CI hardening docs Documentation work examples Examples and sample applications LSP Language server and editor tooling labels Jun 27, 2026
@cssbruno cssbruno changed the title [codex] enable strict golangci-lint ci: enable strict golangci-lint Jun 27, 2026
@cssbruno

Copy link
Copy Markdown
Owner Author

Closing because the head branch used the old codex/* naming pattern. Reopening from ci/strict-golangci-lint.

@cssbruno cssbruno closed this Jun 27, 2026
@cssbruno cssbruno deleted the codex/strict-golangci-lint branch June 27, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Generated browser enhancement runtime compiler Compiler internals, pipeline, and generated metadata docs Documentation work examples Examples and sample applications generated Go Generated Go source and adapter output IR Internal compiler IR and phase handoffs LSP Language server and editor tooling ops Operations, release, deployment, and CI hardening parser .gwdk parser and syntax handling runtime GOWDK Runtime packages and server behavior security Security hardening and security-sensitive behavior SSR Request-time page rendering WASM Go js/wasm artifacts and islands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant