Bugfix/vue not loading (#1110)

* replace minor? with minor

* copilot fix

* revert?

* edit migration

Author: lodewiges

app/controllers/activities_controller.rb

@@ -168,7 +168,7 @@ def users_hash
     users_credits = User.calculate_credits
     User.active.order(:name).map do |user|
       user.current_activity = @activity
-      user.as_json(methods: %i[avatar_thumb_or_default_url minor? insufficient_credit can_order])
+      user.as_json(methods: %i[avatar_thumb_or_default_url minor insufficient_credit can_order])
           .merge(credit: users_credits.fetch(user.id, 0))
     end
   end

app/models/user.rb

@@ -38,7 +38,7 @@ def age
     age
   end
 
-  def minor?
+  def minor
     return false unless age
 
     age < 18
@@ -126,7 +126,7 @@ def self.calculate_spendings(from: '01-01-1970', to: Time.zone.now)
   end
 
   def self.orderscreen_json_includes
-    %i[credit avatar_thumb_or_default_url minor? insufficient_credit can_order]
+    %i[credit avatar_thumb_or_default_url minor insufficient_credit can_order]
   end
 
   private

app/views/activities/order_screen.html.erb

@@ -162,9 +162,9 @@
   </div>
   <div class="product-grid" v-if="selectedUser || payWithCash || payWithPin">
     <div @click="selectProduct(productPrice)" class="product-grid-product"
-         :class="{ 'product-requires-age' : (selectedUser && selectedUser.minor? && productPrice.product.requires_age) }"
+         :class="{ 'product-requires-age' : (selectedUser && selectedUser.minor && productPrice.product.requires_age) }"
          v-for="productPrice in productPrices">
-      <span class="product-grid-product-requires-age mb-2 fa-stack" v-if="selectedUser && selectedUser.minor? && productPrice.product.requires_age">
+      <span class="product-grid-product-requires-age mb-2 fa-stack" v-if="selectedUser && selectedUser.minor && productPrice.product.requires_age">
         <i class="fa fa-circle fa-circle-lighter fa-stack-2x">
         </i>
         <span class="fa fa-stack-1x fa-inverse fa-plus18">

db/migrate/20251026202155_remove_order_total_from_orders.rb

@@ -1,5 +1,5 @@
 class RemoveOrderTotalFromOrders < ActiveRecord::Migration[7.2]
   def change
-    remove_column :orders, :order_total, :decimal
+    remove_column :orders, :order_total, :decimal, precision: 8, scale: 2
   end
 end

spec/models/user_spec.rb

@@ -164,21 +164,21 @@
     end
   end
 
-  describe '#minor?' do
+  describe '#minor' do
     context 'when without age' do
-      it { expect(user.minor?).to be false }
+      it { expect(user.minor).to be false }
     end
 
     context 'when 18 or older' do
       let(:user) { build(:user, birthday: 18.years.ago - 1.day) }
 
-      it { expect(user.minor?).to be false }
+      it { expect(user.minor).to be false }
     end
 
     context 'when younger than 18' do
       let(:user) { build(:user, birthday: (18.years.ago + 1.day)) }
 
-      it { expect(user.minor?).to be true }
+      it { expect(user.minor).to be true }
     end
   end