Make PDF generation Url based instead of htmlbased (#1212)

* intial commit

* simplyfy calls

* make pdf not have a max length

* hide payment status from client

* fix lint

* coderabbit suggestion

Author: lodewiges

app/controllers/invoices_controller.rb

@@ -20,6 +20,10 @@ def show
     # Authorize for authenticated access (integer ID), skip for token-based access
     authorize @invoice, :show? unless token_based_access
 
+    # Hide navbar when generating PDF
+    @show_navigationbar = params[:pdf].blank?
+    @show_extras = params[:pdf].blank?
+
     respond_to do |format|
       format.html
       format.pdf { render_invoice_pdf }
@@ -93,16 +97,14 @@ def permitted_attributes
     params.require(:invoice).permit(%i[user_id activity_id name_override email_override rows], rows_attributes: %i[name amount price])
   end
 
-  def render_invoice_pdf # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+  # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+  def render_invoice_pdf
     token_based_access = !integer_id?(params[:id])
     authorize @invoice, :download? unless token_based_access
 
-    html = render_to_string(
-      template: 'invoices/show',
-      formats: [:html],
-      layout: 'pdf'
-    )
-    pdf = Grover.new(html).to_pdf
+    # Use token-based URL for unauthenticated Grover access
+    url = invoice_url(@invoice.token, pdf: true, only_path: false)
+    pdf = Grover.new(url).to_pdf
     send_data pdf, filename: "Factuur-#{@invoice.human_id}.pdf", type: 'application/pdf', disposition: 'attachment'
   rescue StandardError => e
     Rails.logger.error "Failed to generate PDF for invoice #{@invoice.id}: #{e.message}"
@@ -113,4 +115,5 @@ def render_invoice_pdf # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       redirect_to invoice_path(@invoice)
     end
   end
+  # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 end

app/mailers/invoice_mailer.rb

@@ -10,12 +10,9 @@ def invoice_mail(invoice) # rubocop:disable Metrics/AbcSize, Metrics/MethodLengt
     end
 
     begin
-      html = render_to_string(
-        template: 'invoices/show',
-        formats: [:html],
-        layout: 'pdf'
-      )
-      pdf = Grover.new(html).to_pdf
+      # Use token-based URL for unauthenticated Grover access
+      url = url_for(controller: 'invoices', action: 'show', id: invoice.token, pdf: true, only_path: false)
+      pdf = Grover.new(url).to_pdf
       attachments["#{invoice.human_id}.pdf"] = pdf
     rescue StandardError => e
       Rails.logger.error "Failed to generate PDF attachment for invoice #{invoice.id}: #{e.message}"

app/views/invoices/show.html.erb

@@ -48,6 +48,7 @@
             <%= Rails.application.config.x.company_kvk %>
           </td>
         </tr>
+        <% if current_user&.treasurer? %>
         <tr>
           <th scope="row">
             Status
@@ -60,10 +61,11 @@
             <% end %>
           </td>
         </tr>
+        <% end %>
         </tbody>
       </table>
 
-      <% unless @invoice.paid? %>
+      <% if !@invoice.paid? && Rails.application.config.x.mollie_api_key.present? %>
         <%= link_to pay_invoice_url @invoice.token do %>
           <button class="col-sm-3 offset-sm-9 btn btn-primary">Betalen</button>
         <% end %>

app/views/layouts/pdf.html.erb

@@ -1,31 +1,22 @@
-# Grover Global Configuration
-#
-# Use this to set up shared configuration options for your entire application.
-# Any of the configuration options shown here can also be applied to single
-# models by passing arguments to the Grover.new call.
-#
-# To learn more, check out the README:
-# https://github.com/Studiosity/grover
-
 Grover.configure do |config|
-  options = {
-    format: 'A4',
+  config.options = {
+    viewport: {
+      width: 794,  # A4 width in pixels at 96 DPI (210mm)
+      height: 1123 # Starting height, will expand as needed
+    },
+    emulate_media: 'screen',
     print_background: true,
-    prefer_css_page_size: false,
-    display_url: "https://#{Rails.application.config.x.sofia_host}"
+    executable_path: Rails.env.development? ? nil : '/usr/bin/chromium',
+    launch_args: if Rails.env.development?
+                   []
+                 else
+                   [
+                     '--no-sandbox',
+                     '--disable-setuid-sandbox',
+                     '--disable-dev-shm-usage',
+                     '--disable-gpu',
+                     '--disable-software-rasterizer'
+                   ]
+                 end
   }
-
-  unless Rails.env.development?
-    options[:executable_path] = '/usr/bin/chromium'
-    options[:launch_args] = [
-      '--no-sandbox',
-      '--disable-setuid-sandbox',
-      '--disable-dev-shm-usage',
-      '--disable-gpu',
-      '--disable-software-rasterizer',
-      '--hide-scrollbars'
-    ]
-  end
-
-  config.options = options
 end