Make product name mutable again (#1007)

* make product names mutable again

* Add context for updating product name in specs

* Fix indentation and formatting in product_spec.rb

* add warning when changing product name

* Fix lintS

---------

Co-authored-by: lodewiges <131907615+lodewiges@users.noreply.github.com>
Co-authored-by: Lodewiges <jamestreeg@gmail.com>

Author: DrumsnChocolate

app/javascript/packs/price_lists.js

@@ -55,6 +55,11 @@ document.addEventListener('turbolinks:load', () => {
         },
 
         saveProduct: function(product) {
+          if (product.id && product._beforeEditingCache.name !== product.name) {
+            if (!confirm('Weet je zeker dat je de productnaam wilt wijzigen? Pas hier mee op want dit kan problemen geven in bestaande orders. Als je twijfelt, maak dan een nieuw product aan in plaats van het bestaande te hernoemen.')) {
+              return;
+            }
+          }
           const sanitizedProduct = this.sanitizeProductInput(product);
           if (sanitizedProduct.id) { // Existing product
             this.$http.put(`/products/${sanitizedProduct.id}.json`, { product: sanitizedProduct }).then( (response) => {

app/models/product.rb

@@ -6,7 +6,6 @@ class Product < ApplicationRecord
   has_many :price_lists, through: :product_prices, dependent: :restrict_with_error
 
   validates :name, :category, presence: true
-  validate :name_readonly
 
   accepts_nested_attributes_for :product_prices, allow_destroy: true
 
@@ -17,12 +16,4 @@ def requires_age
   def t_category
     I18n.t category
   end
-
-  private
-
-  def name_readonly
-    return if new_record?
-
-    errors.add(:name, 'is readonly') if name_changed?
-  end
 end

app/views/price_lists/index.html.erb

@@ -25,11 +25,11 @@
         <div class="form-check">
           <input class="form-check-input" type="checkbox" id="show-archived-check" v-model="showArchived">
           <label class="form-check-label" for="show-archived-check">
-            Laat gearchieveerde prijslijsten zien 
+            Laat gearchieveerde prijslijsten zien
           </label>
         </div>
       <% end %>
-      
+
       <table id='price-lists-table' class='price-lists-table table table-striped overflow-scroll mw-100 mx-auto d-block pe-2'>
         <thead class="table-header-rotated products">
         <tr>
@@ -60,7 +60,7 @@
             </td>
             <td class="products-new products-name">
               <div class="d-flex">
-                <input class="form-control flex-grow-1" placeholder="Productnaam" type="text" v-model="product.name" :disabled="product.id"/>
+                <input class="form-control flex-grow-1" placeholder="Productnaam" type="text" v-model="product.name">
               </div>
             </td>
             <td class="products-new products-category">

spec/models/product_spec.rb

@@ -21,7 +21,7 @@
     context 'when updating the name' do
       subject(:product) { create(:product) }
 
-      it { expect(product.update(name: 'new_name')).to be false }
+      it { expect(product.update(name: 'new_name')).to be true }
     end
   end