Remove the user sync button and related code (#1168)

Author: lodewiges

app/controllers/users_controller.rb

@@ -97,19 +97,6 @@ def update
     redirect_to @user
   end
 
-  def refresh_user_list
-    authorize User
-
-    users_json.each do |user_json|
-      find_or_create_user(user_json)
-    end
-
-    users_not_in_json = User.active.in_amber.where.not(uid: users_json.pluck('id')).where.not(name: 'Streepsysteem Flux')
-    users_not_in_json.each(&:archive!)
-
-    redirect_to users_path
-  end
-
   def search
     authorize User
 
@@ -165,11 +152,6 @@ def update_with_sofia_account # rubocop:disable Metrics/AbcSize, Metrics/MethodL
 
   private
 
-  def users_json
-    JSON.parse(RestClient.get("#{Rails.application.config.x.amber_api_url}/api/v1/users?filter[group]=Leden",
-                              'Authorization' => "Bearer #{api_token}"))['data']
-  end
-
   def find_or_create_user(user_json) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     fields = user_json['attributes']
     u = User.find_or_initialize_by(uid: user_json['id'])

app/policies/user_policy.rb

@@ -3,10 +3,6 @@ def index?
     user&.treasurer? || user&.renting_manager? || user&.main_bartender?
   end
 
-  def refresh_user_list?
-    user&.treasurer?
-  end
-
   def search?
     index?
   end

app/views/users/index.html.erb

@@ -27,14 +27,6 @@
     <% if Rails.application.config.x.amber_api_host.present? %>
       <div class="d-flex justify-content-between align-items-center">
         <h3><%= Rails.application.config.x.site_association %> gebruikers</h3>
-        <% if policy(User).refresh_user_list? %>
-          <span>
-            <%= link_to refresh_user_list_users_path, class: 'btn btn-primary btn-sm me-1' do %>
-              <i class="fas fa-arrows-rotate"></i>
-              <span class="d-none d-md-inline ms-1">Synchroniseer gebruikers</span>
-            <% end %>
-          </span>
-        <% end %>
       </div>
       <users-table :users="amber_users" class="mb-5"></users-table>
     <% end %>

config/routes.rb

@@ -21,7 +21,6 @@
 
   resources :users, only: %i[index show create update] do
     collection do
-      get :refresh_user_list
       post :search
     end
     member do