make deposit button env configurabliable (#1171)

* make deposit button env configurabliable

* Fix small bug

Author: lodewiges

.env.example

@@ -49,5 +49,6 @@ CODE_CASH=1000
 CODE_PIN=2060
 
 MIN_PAYMENT_AMOUNT=21.8
+DEPOSIT_BUTTON_ENABLED=true
 
 DOCKER_PASSWORD=somethingsomething

app/javascript/components/orderscreen/UserSelection.vue

@@ -23,7 +23,7 @@
             {{doubleToCurrency(selectedUser.credit)}}
           </h3>
 
-          <button type="button" class="btn btn-secondary" data-bs-toggle="modal" data-bs-target="#credit-mutation-modal">
+          <button v-if="depositButtonEnabled" type="button" class="btn btn-secondary" data-bs-toggle="modal" data-bs-target="#credit-mutation-modal">
             <i class="fa fa-money-bill me-1"></i>
             Geld inleggen
           </button>
@@ -104,6 +104,10 @@ export default {
     selectedUser: Object,
     payWithCash: Boolean,
     payWithPin: Boolean,
+    depositButtonEnabled: {
+      type: Boolean,
+      default: true
+    },
     users: {
       type: Array,
       required: true

app/javascript/order_screen.js

@@ -19,6 +19,7 @@ document.addEventListener('turbo:load', () => {
     const productPrices = JSON.parse(element.dataset.productPrices);
     const activity = JSON.parse(element.dataset.activity);
     const flashes = JSON.parse(element.dataset.flashes);
+    const depositButtonEnabled = element.dataset.depositButtonEnabled === 'true';
 
     window.flash = function(message, actionText, type) {
       const event = new CustomEvent('flash', { detail: { message: message, actionText: actionText, type: type } } );
@@ -42,6 +43,7 @@ document.addEventListener('turbo:load', () => {
           payWithCash: false,
           payWithPin: false,
           keepUserSelected: false,
+          depositButtonEnabled: depositButtonEnabled,
           orderRows: [],
           isSubmitting: false
         };

app/views/activities/order_screen.html.erb

@@ -3,7 +3,7 @@
   <%= javascript_include_tag "order_screen", "data-turbo-track": "reload", defer: true %>
 <% end %>
 <%= content_tag :div, id: 'order-screen', class: 'order-screen',
-                data: {users: @users_json, product_prices: @product_prices_json, activity: @activity_json, sumup_callback: sumup_callback_activity_url, sumup_key: @sumup_key, flashes: flash, site_name: Rails.application.config.x.site_short_name} do
+                data: {users: @users_json, product_prices: @product_prices_json, activity: @activity_json, sumup_callback: sumup_callback_activity_url, sumup_key: @sumup_key, flashes: flash, site_name: Rails.application.config.x.site_short_name, deposit_button_enabled: Rails.application.config.x.deposit_button_enabled} do
 
 %>
 
@@ -56,7 +56,7 @@
   </nav>
   <div class="side-panel">
     <user-selection :pay-with-cash="payWithCash" :pay-with-pin="payWithPin" :selected-user="selectedUser"
-                    :users="users" v-on:selectcash="selectCash" v-on:selectpin="selectPin" v-on:updateuser="setUser($event)">
+                    :users="users" :deposit-button-enabled="depositButtonEnabled" v-on:selectcash="selectCash" v-on:selectpin="selectPin" v-on:updateuser="setUser($event)">
     </user-selection>
     <div class="orders" v-if="selectedUser || payWithCash || payWithPin">
       <h4 class="orders-header py-4">

app/views/users/show.html.erb

@@ -152,7 +152,7 @@
               </div>
               <p class="card-text d-none d-md-block">
                 <%= 'Rechten zijn afhankelijk van de rollen die een gebruiker in het streepsysteem heeft. ' %>
-                <% if Rails.application.config.x.amber_api_url.present? %>
+                <% if Rails.application.config.x.amber_api_host.present? %>
                   <%= 'Rollen worden bepaald aan de hand van de groepen waar een gebruiker lid van is in de gekoppelde website.' %>
                 <% else %>
                   <%= 'Rollen kunnen geconfigureerd worden via de console van de serviceprovider.' %>

config/application.rb

@@ -75,6 +75,7 @@ class Application < Rails::Application
     config.x.site_short_name      = ENV.fetch('SITE_SHORT_NAME', 'SOFIA')
     config.x.site_long_name       = ENV.fetch('SITE_LONG_NAME', 'Streepsysteem voor de Ordentelijke Festiviteiten van Inleggend Alpha')
     config.x.site_association     = ENV.fetch('SITE_ASSOCIATION', 'C.S.V. Alpha')
+    config.x.deposit_button_enabled = ENV.fetch('DEPOSIT_BUTTON_ENABLED', 'true') == 'true'
 
     config.x.min_payment_amount   = [ENV.fetch('MIN_PAYMENT_AMOUNT', '21.8').to_f, 0.01].max