Skip to content

R1- and DL0-waveform data model#85

Open
jlenain wants to merge 10 commits into
cta-observatory:mainfrom
jlenain:r1_data_model
Open

R1- and DL0-waveform data model#85
jlenain wants to merge 10 commits into
cta-observatory:mainfrom
jlenain:r1_data_model

Conversation

@jlenain
Copy link
Copy Markdown
Contributor

@jlenain jlenain commented Apr 21, 2026

In ctapipe 0.21, the expected shape of R1 and DL0 waveforms changed from (n_pixels, n_samples) to be always (n_channels, n_pixels, n_samples) (see https://ctapipe.readthedocs.io/en/latest/changelog.html#id50).

At the moment, ctapipe_io_nectarcam is not compatible with the ctapipe version v0.24 pinned to it in this respect, as explained in the issue #81.

This PR proposes a fix to this data model change, as well as, incidentally, a fix for the issue #80.

Note: we should be careful in propagating these changes in nectarchain as well, presumably by un-doing part of the PR cta-observatory/nectarchain#191.

Comment thread src/ctapipe_io_nectarcam/__init__.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.76%. Comparing base (fd555fc) to head (a83064b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ctapipe_io_nectarcam/__init__.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   84.74%   84.76%   +0.02%     
==========================================
  Files           7        7              
  Lines         957      965       +8     
==========================================
+ Hits          811      818       +7     
- Misses        146      147       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent R1/DL0 data model in ctapipe_io_nectarcam Inconsistent size of trigger_pattern in NectarCAMEventContainer

2 participants