R1- and DL0-waveform data model#85
Open
jlenain wants to merge 10 commits into
Open
Conversation
This was
linked to
issues
Apr 21, 2026
vmarandon
reviewed
Apr 21, 2026
…ld be re-enabled, such as parsing the trigger pattern.
…fault and re-order the information according the pixel_ids and module_ids from the service data
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 84.74% 84.76% +0.02%
==========================================
Files 7 7
Lines 957 965 +8
==========================================
+ Hits 811 818 +7
- Misses 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ctapipe0.21, the expected shape of R1 and DL0 waveforms changed from (n_pixels, n_samples) to be always (n_channels, n_pixels, n_samples) (see https://ctapipe.readthedocs.io/en/latest/changelog.html#id50).At the moment,
ctapipe_io_nectarcamis not compatible with thectapipeversion v0.24 pinned to it in this respect, as explained in the issue #81.This PR proposes a fix to this data model change, as well as, incidentally, a fix for the issue #80.
Note: we should be careful in propagating these changes in
nectarchainas well, presumably by un-doing part of the PR cta-observatory/nectarchain#191.