Add test for deadtime and event time-difference distributions to Acceptance Verification#311
Conversation
- gui.py: refactor to add deadtime test - deadtime.py: implement placeholder for deadtime test following TRR test suite logic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 49.33% 45.57% -3.77%
==========================================
Files 85 89 +4
Lines 7795 8616 +821
==========================================
+ Hits 3846 3927 +81
- Misses 3949 4689 +740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- ../trr_test_suite/deadtime.py: fix typo in docstring - deadtime.py: implement computation and plots for deadtime and event time distributions, following login in trr_test_suite - resources/source_type_labels.json: add labels and colors for source type, following what defined in ctapipe.containers.EventType
| output_dir, | ||
| temp_output, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Perhaps add also a band or line that visualizes the requirement B-TEL-1270 (+B-MST-1280), i.e. deadtime < 5% for trigger rates up to 7 MHz.
There was a problem hiding this comment.
Yes, will do. This is still a draft PR anyway because I haven't fully tested it.
- deadtime.py: minor typo fixes, minor refactors in functions to accept acceptance verification inputs - utils.py: minor refactors in plot_deadtime_and_expo_fit to accept input for acceptance verification - tools_components.py: refactor in DeadtimeTestTool to extract event_type from ctapipe.containers.EventType
- utils.py: refactor plot_deadtime_and_expo_fit with temporary output for the GUI
- resources/source_type_labels.json: change color for SUBARRAY to pink - deadtime.py: docstring and refactor few function arguments to display in the GUI
|
Hi @tibaldo, with these last few pushes, this PR satisfies the same requirements as for the TRR deadtime test, and produces the plots for the GUI in you can get the plots below: 
You can also visualise the same plots via the GUI (in which you'll see the distributions for all the runs). |
3 participants
feat(src/nectarchain/acceptance_verification_package):
This PR will implement the test to plot deadtime and event time-difference distributions for the acceptance verification on site. It follows the logic already implemented for the TRR test suite.