Skip to content

Fix IRF interpolation on macos#307

Merged
maxnoe merged 7 commits into
mainfrom
fix_interpolation_macos_arm
Jun 1, 2026
Merged

Fix IRF interpolation on macos#307
maxnoe merged 7 commits into
mainfrom
fix_interpolation_macos_arm

Conversation

@maxnoe

@maxnoe maxnoe commented Aug 14, 2025

Copy link
Copy Markdown
Member

Fixes #306

@maxnoe
maxnoe requested a review from HealthyPear as a code owner August 14, 2025 10:17
@maxnoe
maxnoe force-pushed the fix_interpolation_macos_arm branch from c5fa3fe to 84a7146 Compare August 14, 2025 10:18
@maxnoe
maxnoe requested a review from RuneDominik as a code owner August 14, 2025 10:23
@maxnoe
maxnoe requested a review from kosack September 18, 2025 11:01
RuneDominik
RuneDominik previously approved these changes Sep 24, 2025

@RuneDominik RuneDominik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original use of long double in the type check was, as far as I rember, only done to assert that even the use of a long double as input does not break the function. Thus, the check against float_max should preserve the orginal intent.

moralejo
moralejo previously approved these changes Mar 13, 2026
@moralejo

Copy link
Copy Markdown
Contributor

Can this be merged?

@maxnoe
maxnoe force-pushed the fix_interpolation_macos_arm branch from 3077252 to a669c63 Compare June 1, 2026 15:06
@maxnoe maxnoe added this to the v0.14.0 milestone Jun 1, 2026
@maxnoe
maxnoe dismissed stale reviews from moralejo and RuneDominik via 536cd90 June 1, 2026 15:09
kosack
kosack previously approved these changes Jun 1, 2026
@maxnoe
maxnoe force-pushed the fix_interpolation_macos_arm branch from 536cd90 to bc3dd5e Compare June 1, 2026 15:24
@maxnoe

maxnoe commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

sorry @kosack, this one needed a rebase after the other merges.

@maxnoe
maxnoe merged commit 12a7d54 into main Jun 1, 2026
9 checks passed
@maxnoe
maxnoe deleted the fix_interpolation_macos_arm branch June 1, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion of replacing np.float128 with np.float64 in pyirf to support IRF interpolation on macOS

4 participants