ensure functionality of file access is complete

Author: saimonation

cterasdk/asynchronous/core/files/browser.py

@@ -47,22 +47,23 @@ async def download(self, path, destination=None):
         """
         return await Download(io.handle, self._core, path, destination).a_execute()
 
-    async def download_many(self, target, objects, destination=None):
+    async def download_many(self, directory, objects, destination=None):
         """
         Download selected files and/or directories as a ZIP archive.
 
         .. warning::
             Only existing files and directories will be included in the resulting ZIP file.
 
-        :param str target: Path to cloud folder containing files and directories.
-        :param list[str] objects: List of file and/or directory names to include.
+        :param str directory: Path to a folder.
+        :param list[str] objects: List of files and / or directory names to download.
         :param str destination: Optional path to destination file or directory. Defaults to default download directory.
         :returns: Path to local file.
         :rtype: str
         :raises cterasdk.exceptions.io.core.GetMetadataError: If directory not found.
         :raises cterasdk.exceptions.io.core.NotADirectoryException: If target path is not a directory.
         """
-        return await DownloadMany(io.handle_many, self._core, target, objects, destination).a_execute()
+        async with EnsureDirectory(io.listdir, self._core, directory) as (_, resource):
+            return await DownloadMany(io.handle_many, self._core, resource, directory, objects, destination).a_execute()
 
     async def listdir(self, path=None, include_deleted=False):
         """

cterasdk/cio/core/commands.py

@@ -365,7 +365,7 @@ class OpenMany(PortalCommand):
 
     def __init__(self, function, receiver, resource, directory, *objects):
         super().__init__(function, receiver)
-        self.cloudfolder = str(resource.cloudFolderInfo.uid)
+        self.uid = str(resource.cloudFolderInfo.uid)
         self.directory = automatic_resolution(directory, receiver.context)
         self.objects = objects
 
@@ -383,38 +383,39 @@ def get_parameter(self):
 
     def _execute(self):
         with self.trace_execution():
-            return self._function(self._receiver, self.cloudfolder, self.get_parameter())
+            return self._function(self._receiver, self.uid, self.get_parameter())
 
     async def _a_execute(self):
         with self.trace_execution():
-            return await self._function(self._receiver, self.cloudfolder, self.get_parameter())
+            return await self._function(self._receiver, self.uid, self.get_parameter())
 
 
 class DownloadMany(PortalCommand):
 
-    def __init__(self, function, receiver, target, objects, destination):
+    def __init__(self, function, receiver, resource, directory, objects, destination):
         super().__init__(function, receiver)
-        self.target = automatic_resolution(target, receiver.context)
+        self.resource = resource
+        self.directory = automatic_resolution(directory, receiver.context)
         self.objects = objects
         self.destination = destination
 
     def get_parameter(self):
-        return commonfs.determine_directory_and_filename(self.target.reference, self.objects, destination=self.destination, archive=True)
+        return commonfs.determine_directory_and_filename(self.directory.reference, self.objects, destination=self.destination, archive=True)
 
     def _before_command(self):
         for o in self.objects:
-            logger.info('Downloading: %s', self.target.join(o).relative)
+            logger.info('Downloading: %s', self.directory.join(o).relative)
 
     def _execute(self):
         directory, name = self.get_parameter()
         with self.trace_execution():
-            with OpenMany(self._function, self._receiver, self.target, *self.objects) as handle:
+            with OpenMany(self._function, self._receiver, self.resource, self.directory, *self.objects) as handle:
                 return synfs.write(directory, name, handle)
 
     async def _a_execute(self):
         directory, name = self.get_parameter()
         with self.trace_execution():
-            async with OpenMany(self._function, self._receiver, self.target, *self.objects) as handle:
+            async with OpenMany(self._function, self._receiver, self.resource, self.directory, *self.objects) as handle:
                 return await asynfs.write(directory, name, handle)
 
 

cterasdk/core/files/browser.py

@@ -48,22 +48,23 @@ def download(self, path, destination=None):
         """
         return Download(io.handle, self._core, path, destination).execute()
 
-    def download_many(self, target, objects, destination=None):
+    def download_many(self, directory, objects, destination=None):
         """
         Download selected files and/or directories as a ZIP archive.
 
         .. warning::
             Only existing files and directories will be included in the resulting ZIP file.
 
-        :param str target: Path to the cloud folder containing files and directories.
-        :param list[str] objects: List of file and/or directory names to include.
+        :param str directory: Path to a folder.
+        :param list[str] objects: List of files and / or directory names to download.
         :param str destination: Optional path to destination file or directory. Defaults to the default download directory.
         :returns: Path to the local file.
         :rtype: str
         :raises cterasdk.exceptions.io.core.GetMetadataError: If the directory was not found.
         :raises cterasdk.exceptions.io.core.NotADirectoryException: If the target path is not a directory.
         """
-        return DownloadMany(io.handle_many, self._core, target, objects, destination).execute()
+        with EnsureDirectory(io.listdir, self._core, directory) as (_, resource):
+            return DownloadMany(io.handle_many, self._core, resource, directory, objects, destination).execute()
 
     def listdir(self, path=None, include_deleted=False):
         """