Skip to content

do not instantiate tcp connector before creating an asynchronous loop #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saimonation merged 1 commit into from
May 19, 2025
Merged

do not instantiate tcp connector before creating an asynchronous loop #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cterasdk/clients/async_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@
class Session:
"""Asynchronous HTTP Session"""

def __init__(self, **kwargs):
self._kwargs = kwargs
def __init__(self, settings, trace):
self._settings = settings
self._trace = trace
self._session = None

@property
def session(self):
if self.closed:
self._session = aiohttp.ClientSession(**self._kwargs)
self._session = aiohttp.ClientSession(**self._settings, **self._trace)
return self._session

@property
Expand Down
2 changes: 1 addition & 1 deletion cterasdk/clients/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(self, builder=None, session=None, settings=None, authenticator=None
if settings:
default_settings.update(**settings.kwargs)

self._session = session if session else async_requests.Session(**default_settings, **TraceSettings())
self._session = session if session else async_requests.Session(default_settings, TraceSettings())

def clone(self, definition, builder=None, authenticator=None):
"""
Expand Down