Skip to content

chore: introduced golangci-lint#25

Merged
Ma11hewThomas merged 1 commit into
ctrf-io:mainfrom
fredbi:chore/renovate
Nov 23, 2025
Merged

chore: introduced golangci-lint#25
Ma11hewThomas merged 1 commit into
ctrf-io:mainfrom
fredbi:chore/renovate

Conversation

@fredbi
Copy link
Copy Markdown
Collaborator

@fredbi fredbi commented Nov 23, 2025

This PR introduces golangci-lint, a meta linter for go.

It adds a config, which is not the default.

It fixes a few issues detected by linters. Not all of them.

CI now enforces linting on new or modified code. Relinting the existing code can be done progressively over time.

Since this PR is about modernization, it refreshes the go versions in tests and uses symbolic versions (stable, oldstable) to remain up-to-date over time. Compat. with go1.19 remains unchanged.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 23, 2025

Pull Request Test Coverage Report for Build 19614545240

Details

  • 4 of 12 (33.33%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.3%) to 57.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
reporter/reporter.go 4 5 80.0%
cmd/go-ctrf-json-reporter/main.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
reporter/reporter.go 1 70.25%
Totals Coverage Status
Change from base Build 19614481991: -1.3%
Covered Lines: 210
Relevant Lines: 364

💛 - Coveralls

This PR introduces golangci-lint, a meta linter for go.

It adds a config, which is not the default.

It fixes a few issues detected by linters. Not all of them.

CI now enforces linting on new or modified code. Relinting the existing
code can be done progressively over time.

Since this PR is about modernization, it refreshes the go versions in
tests and uses symbolic versions (stable, oldstable) to remain
up-to-date over time. Compat. with go1.19 remains unchanged.

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
@Ma11hewThomas Ma11hewThomas merged commit 3f1c615 into ctrf-io:main Nov 23, 2025
5 checks passed
@fredbi fredbi deleted the chore/renovate branch November 23, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants