Add revisionHistoryLimit to Ledger#201
Merged
Merged
Conversation
TheWitness
approved these changes
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the number of retained historical ReplicaSets for the Ledger db, parser, and web Deployments by explicitly setting spec.revisionHistoryLimit: 1 (instead of relying on the Kubernetes default of 10). This helps limit accumulation of old ReplicaSets across supported cluster platforms.
Changes:
- Add
revisionHistoryLimit: 1to thedbDeployment in each platform-specific Ledger manifest template. - Add
revisionHistoryLimit: 1to theparserDeployment in each platform-specific Ledger manifest template. - Add
revisionHistoryLimit: 1to thewebDeployment in each platform-specific Ledger manifest template.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| playbooks/roles/ledger_install/templates/ledger_deployment_rke2.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on RKE2. |
| playbooks/roles/ledger_install/templates/ledger_deployment_ocp.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on OpenShift. |
| playbooks/roles/ledger_install/templates/ledger_deployment_k3s.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on K3s. |
| playbooks/roles/ledger_install/templates/ledger_deployment_gke.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on GKE. |
| playbooks/roles/ledger_install/templates/ledger_deployment_eks.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on EKS. |
| playbooks/roles/ledger_install/templates/ledger_deployment_dkp.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on DKP. |
| playbooks/roles/ledger_install/templates/ledger_deployment_aks.yaml | Sets revisionHistoryLimit: 1 for Ledger Deployments on AKS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default for keeping old replicasets around is 10, lets drop that down to 1 so we aren't keeping so many old ones around.