Skip to content

Fix issue with approval count not reflecting saved value#590

Merged
cigamit merged 1 commit into
mainfrom
fix_approval_count
Jul 20, 2026
Merged

Fix issue with approval count not reflecting saved value#590
cigamit merged 1 commit into
mainfrom
fix_approval_count

Conversation

@cigamit

@cigamit cigamit commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This fixes an issue where, when editing an Approval Node, the values for "Required approvals", "On timeout", and "Context Template" where not properly reflecting the values that were saved previously.

@cigamit
cigamit requested a review from TheWitness July 20, 2026 17:30
@cigamit cigamit self-assigned this Jul 20, 2026
@cigamit cigamit added the bug Something isn't working label Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes workflow Approval Node editing in the UI/API by ensuring the node’s summary_fields.unified_job_template includes the saved Approval Template configuration values (so previously-saved “Required approvals”, “On timeout”, and “Context Template” can be reliably displayed when re-opening/editing a node).

Changes:

  • Extend WorkflowJobTemplateNodeSerializer.get_summary_fields() to include required_approvals, on_timeout, and context_template for Approval nodes (in addition to timeout).
  • Add a functional API test asserting these fields are returned via the workflow node detail endpoint after creating an approval template on a node.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
awx/main/tests/functional/api/test_workflow_node.py Adds a functional test to verify approval template values are present in workflow node summary_fields after creation.
awx/api/serializers.py Populates additional Approval Template fields (required_approvals, on_timeout, context_template) in workflow node summary_fields for Approval nodes.

@cigamit
cigamit merged commit f5f1fc0 into main Jul 20, 2026
1 check passed
@cigamit
cigamit deleted the fix_approval_count branch July 20, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

3 participants