Fix issue with approval count not reflecting saved value#590
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes workflow Approval Node editing in the UI/API by ensuring the node’s summary_fields.unified_job_template includes the saved Approval Template configuration values (so previously-saved “Required approvals”, “On timeout”, and “Context Template” can be reliably displayed when re-opening/editing a node).
Changes:
- Extend
WorkflowJobTemplateNodeSerializer.get_summary_fields()to includerequired_approvals,on_timeout, andcontext_templatefor Approval nodes (in addition totimeout). - Add a functional API test asserting these fields are returned via the workflow node detail endpoint after creating an approval template on a node.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
awx/main/tests/functional/api/test_workflow_node.py |
Adds a functional test to verify approval template values are present in workflow node summary_fields after creation. |
awx/api/serializers.py |
Populates additional Approval Template fields (required_approvals, on_timeout, context_template) in workflow node summary_fields for Approval nodes. |
TheWitness
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where, when editing an Approval Node, the values for "Required approvals", "On timeout", and "Context Template" where not properly reflecting the values that were saved previously.