Skip to content

Commit adec539

Browse files
CIQ Kernel Automationroxanan1996
authored andcommitted
nbd: defer config unlock in nbd_genl_connect
jira VULN-171935 cve CVE-2025-68366 commit-author Zheng Qixing <zhengqixing@huawei.com> commit 1649714 There is one use-after-free warning when running NBD_CMD_CONNECT and NBD_CLEAR_SOCK: nbd_genl_connect nbd_alloc_and_init_config // config_refs=1 nbd_start_device // config_refs=2 set NBD_RT_HAS_CONFIG_REF open nbd // config_refs=3 recv_work done // config_refs=2 NBD_CLEAR_SOCK // config_refs=1 close nbd // config_refs=0 refcount_inc -> uaf ------------[ cut here ]------------ refcount_t: addition on 0; use-after-free. WARNING: CPU: 24 PID: 1014 at lib/refcount.c:25 refcount_warn_saturate+0x12e/0x290 nbd_genl_connect+0x16d0/0x1ab0 genl_family_rcv_msg_doit+0x1f3/0x310 genl_rcv_msg+0x44a/0x790 The issue can be easily reproduced by adding a small delay before refcount_inc(&nbd->config_refs) in nbd_genl_connect(): mutex_unlock(&nbd->config_lock); if (!ret) { set_bit(NBD_RT_HAS_CONFIG_REF, &config->runtime_flags); + printk("before sleep\n"); + mdelay(5 * 1000); + printk("after sleep\n"); refcount_inc(&nbd->config_refs); nbd_connect_reply(info, nbd->index); } Fixes: e46c728 ("nbd: add a basic netlink interface") Signed-off-by: Zheng Qixing <zhengqixing@huawei.com> Reviewed-by: Yu Kuai <yukuai@fnnas.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> (cherry picked from commit 1649714) Signed-off-by: CIQ Kernel Automation <ciq_kernel_automation@ciq.com>
1 parent db06c29 commit adec539

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/block/nbd.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2087,12 +2087,13 @@ static int nbd_genl_connect(struct sk_buff *skb, struct genl_info *info)
20872087
}
20882088
set_bit(NBD_RT_HAS_BACKEND_FILE, &config->runtime_flags);
20892089
out:
2090-
mutex_unlock(&nbd->config_lock);
20912090
if (!ret) {
20922091
set_bit(NBD_RT_HAS_CONFIG_REF, &config->runtime_flags);
20932092
refcount_inc(&nbd->config_refs);
20942093
nbd_connect_reply(info, nbd->index);
20952094
}
2095+
mutex_unlock(&nbd->config_lock);
2096+
20962097
nbd_config_put(nbd);
20972098
if (put_dev)
20982099
nbd_put(nbd);

0 commit comments

Comments
 (0)