Skip to content

Commit b139569

Browse files
author
CIQ Kernel Automation
committed
pwm: Fix double shift bug
jira VULN-35725 cve CVE-2023-52756 commit-author Dan Carpenter <dan.carpenter@linaro.org> commit d27abbf These enums are passed to set/test_bit(). The set/test_bit() functions take a bit number instead of a shifted value. Passing a shifted value is a double shift bug like doing BIT(BIT(1)). The double shift bug doesn't cause a problem here because we are only checking 0 and 1 but if the value was 5 or above then it can lead to a buffer overflow. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com> (cherry picked from commit d27abbf) Signed-off-by: CIQ Kernel Automation <ciq_kernel_automation@ciq.com>
1 parent 05dddb0 commit b139569

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

include/linux/pwm.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ struct pwm_args {
4444
};
4545

4646
enum {
47-
PWMF_REQUESTED = 1 << 0,
48-
PWMF_EXPORTED = 1 << 1,
47+
PWMF_REQUESTED = 0,
48+
PWMF_EXPORTED = 1,
4949
};
5050

5151
/*

0 commit comments

Comments
 (0)