small logic fixes

Author: Omarrasheed

TCAT/Controllers/HomeViewController.swift

@@ -239,6 +239,10 @@ class HomeViewController: UIViewController {
 
     func showWhatsNewCardIfNeeded() {
 
+        if VersionStore.shared.isNewCardAvailable() {
+            userDefaults.set(false, forKey: Constants.UserDefaults.whatsNewDismissed)
+        }
+
         let promotionCardDismissed = userDefaults.bool(forKey: Constants.UserDefaults.promotionDismissed)
         let whatsNewDismissed = userDefaults.bool(forKey: Constants.UserDefaults.whatsNewDismissed)
 

TCAT/Supporting Files/Constants.swift

@@ -239,6 +239,8 @@ struct Constants {
         static let onboardingShown = "onboardingShown"
         static let showLocationAuthReminder = "locationAuthReminder"
         static let uid = "uid"
+        
+        /// True if the current card has been dismissed by user
         static let whatsNewDismissed = "whatsNewDismissed"
         static let recentSearch = "recentSearch"
         static let allBusStops = "allBusStops"

TCAT/Utilities/VersionStore.swift

@@ -39,6 +39,7 @@ class VersionStore: WhatsNewVersionStore {
     }
 
     func storeShownCard(card: WhatsNewCard) {
+        guard !card.isEqual(to: WhatsNewCard.promotion) else { return }
         if let encodedData = try? JSONEncoder().encode(card) {
             userDefaults.set(encodedData, forKey: Constants.UserDefaults.whatsNewCardVersion)
         } else {