Skip to content

Commit 08b2f50

Browse files
authored
Merge pull request #113 from cuappdev/master
Fix ItemSerializer n+1
2 parents 96d8df9 + 2eeff7e commit 08b2f50

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/item/serializers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ class ItemSerializer(serializers.ModelSerializer):
1010

1111
def get_dietary_preferences(self, obj):
1212
"""Get list of dietary preference names"""
13-
return list(obj.dietary_preferences.values_list('name', flat=True))
13+
return [pref.name for pref in obj.dietary_preferences.all()]
1414

1515
def get_allergens(self, obj):
1616
"""Get list of allergen names"""
17-
return list(obj.allergens.values_list('name', flat=True))
17+
return [allergen.name for allergen in obj.allergens.all()]
1818

1919
def create(self, validated_data):
2020
dietary_prefs = validated_data.pop('dietary_preferences', [])

0 commit comments

Comments
 (0)