Require buyer and seller on UserReview at the schema level.

Match the frontend contract by marking the buyer and seller relations as nullable: false and adding a migration that purges orphaned reviews and applies NOT NULL constraints to buyerId and sellerId.

Made-with: Cursor

Author: Xhether

src/migrations/1770000000000-UserReviewBuyerSellerNotNull.ts

@@ -0,0 +1,37 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class UserReviewBuyerSellerNotNull1770000000000
+  implements MigrationInterface
+{
+  name = "UserReviewBuyerSellerNotNull1770000000000";
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    const orphans: Array<{ id: string }> = await queryRunner.query(
+      `SELECT "id" FROM "UserReview" WHERE "buyerId" IS NULL OR "sellerId" IS NULL`,
+    );
+    if (orphans.length > 0) {
+      console.log(
+        `UserReviewBuyerSellerNotNull: removing ${orphans.length} UserReview rows missing buyer or seller before tightening constraints.`,
+      );
+      await queryRunner.query(
+        `DELETE FROM "UserReview" WHERE "buyerId" IS NULL OR "sellerId" IS NULL`,
+      );
+    }
+
+    await queryRunner.query(
+      `ALTER TABLE "UserReview" ALTER COLUMN "buyerId" SET NOT NULL`,
+    );
+    await queryRunner.query(
+      `ALTER TABLE "UserReview" ALTER COLUMN "sellerId" SET NOT NULL`,
+    );
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "UserReview" ALTER COLUMN "sellerId" DROP NOT NULL`,
+    );
+    await queryRunner.query(
+      `ALTER TABLE "UserReview" ALTER COLUMN "buyerId" DROP NOT NULL`,
+    );
+  }
+}

src/models/UserReviewModel.ts

@@ -28,11 +28,15 @@ export class UserReviewModel {
   @CreateDateColumn({ type: "timestamptz" })
   date: Date;
 
-  @ManyToOne(() => UserModel, (buyer) => buyer.reviewsWritten)
+  @ManyToOne(() => UserModel, (buyer) => buyer.reviewsWritten, {
+    nullable: false,
+  })
   @JoinColumn({ name: "buyerId" })
   buyer: UserModel;
 
-  @ManyToOne(() => UserModel, (seller) => seller.reviewsReceived)
+  @ManyToOne(() => UserModel, (seller) => seller.reviewsReceived, {
+    nullable: false,
+  })
   @JoinColumn({ name: "sellerId" })
   seller: UserModel;