feat: add dismissible option to progress toasts#1056
Merged
Conversation
Add ability to restore dismissed notifications when async actions return false. This allows notifications to reappear if an action (e.g., opening a confirmation dialog) is cancelled by the user. Made-with: Cursor
Update progress toasts in-place instead of removing and re-adding, preventing unnecessary exit/enter animations when data changes. Made-with: Cursor
Add isDismissible option that shows a 'Hide' action button during loading, allowing users to temporarily dismiss progress toasts. The toast will not re-appear during the same loading cycle after being dismissed. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3c03ae9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-9583469. |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
🧪 Storybook is successfully deployed!
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Rename isDismissible prop to isDismissable across Banner and Notification components to match the naming convention used in Dialog, LayoutPanel, and other components. This is a breaking change documented in changeset. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk: introduces a breaking prop rename (
isDismissible→isDismissable) and changes overlay notification/toast lifecycle behavior (restore, in-place updates, z-index), which could affect UI stacking and dismissal/persistence edge cases.Overview
Adds an
isDismissableoption to progress toasts, showing a temporary Hide action during loading, and updates progress toasts in-place viaupdateToastto avoid unnecessary exit/enter animations when content changes.Renames
isDismissible→isDismissableacrossBannerandNotification(docs/stories/tests included), and adds notification restore support: actions now dismiss immediately, but if an asynconPressreturnsfalsethe notification is restored, including undoing any persistent side effects.Also removes legacy notification CSS from
GlobalStylesand lowers the overlay containerzIndex(10000→100).Written by Cursor Bugbot for commit 3c03ae9. This will update automatically on new commits. Configure here.