Skip to content

fix(TextArea): mods prop#1096

Merged
tenphi merged 1 commit intomainfrom
fix-text-input-base-mods
Mar 25, 2026
Merged

fix(TextArea): mods prop#1096
tenphi merged 1 commit intomainfrom
fix-text-input-base-mods

Conversation

@tenphi
Copy link
Copy Markdown
Member

@tenphi tenphi commented Mar 25, 2026

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information


Note

Low Risk
Low risk: a small prop-handling change so mods is no longer stripped in TextArea and will flow through to TextInputBase styling modifiers.

Overview
Fixes TextArea so the mods prop is no longer destructured away and instead propagates through ...otherProps into useTextField/TextInputBase, enabling modifier-based styling to work consistently.

Adds a patch changeset noting the mods propagation behavior change.

Written by Cursor Bugbot for commit b5964ac. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: b5964ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cube-ui-kit Ready Ready Preview, Comment Mar 25, 2026 1:09pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-9e7c4c7.

@github-actions
Copy link
Copy Markdown
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Copy Markdown
Contributor

🏋️ Size limit report

Name Size Passed?
All 360.57 KB (-0.01% 🔽👏) Yes 🎉
Tree shaking (just a Button) 101.11 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit 6a28637 into main Mar 25, 2026
16 checks passed
@tenphi tenphi deleted the fix-text-input-base-mods branch March 25, 2026 13:13
@github-actions github-actions Bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant