Merged
Conversation
🦋 Changeset detectedLatest commit: 7ae9c6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-6fd9868. |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
🧪 Storybook is successfully deployed!
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
tenphi
had a problem deploying
to
Chromatic staging
GitHub Actions
Failure
The processSelectionArray function was extracted to src/utils/selection.ts but the file was not committed, causing build failures. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Refactors
FilterPicker/Pickerpopover state and selection/sorting flows; while intended as a perf improvement, it changes open/close and sorting timing and could introduce subtle UI regressions.Overview
Improves
FilterPickerandPickerperformance by making theDialogTriggerpopover fully controlled (isOpen/onOpenChange), moving popover lifecycle effects out of the trigger render path, and memoizing trigger summary rendering.Optimizes selection label/key handling by building memoized
Maplookups (and reusing a shared_internalCollectioninFilterPicker) instead of per-render/per-key scans, and measures trigger width only when opening to avoid layout reads on every render.Updates selected-item sorting so it is computed and cached only while the popover is open, clears caches on close/items changes, and adds
useWarnwarnings whensortSelectedToTopis used without theitemsprop; also extracts duplicated multi-select toggling logic into a new sharedutils/selection.ts(processSelectionArray).Written by Cursor Bugbot for commit 7ae9c6b. This will update automatically on new commits. Configure here.