refactor: generate synthetic link dims after include/exclude logic

Restructured so the compilation order is:
1. View include/exclude logic runs first (CubeSymbols.prepareIncludes)
   - links property is propagated to view dimensions alongside other
     properties like format, granularities, mask
   - Exclude works correctly since synthetic dims don't exist yet
2. Then prepareSyntheticLinkDimensions runs in prepareCube for both
   cubes AND views, generating synthetic dims from whatever dimensions
   survived the include/exclude phase

Removed the previous approach of auto-including synthetic dims during
the include resolution (they didn't exist at that point anyway).
Moved prepareSyntheticLinkDimensions before prepareMembers(dimensions)
so the synthetic dims get full member processing.

Co-authored-by: Pavel Tiunov <pavel.tiunov@gmail.com>

Author: cursoragent

packages/cubejs-schema-compiler/src/compiler/CubeEvaluator.ts

@@ -209,8 +209,8 @@ export class CubeEvaluator extends CubeSymbols {
     this.prepareJoins(cube, errorReporter);
     this.preparePreAggregations(cube, errorReporter);
     this.prepareMembers(cube.measures, cube, errorReporter);
-    this.prepareMembers(cube.dimensions, cube, errorReporter);
     this.prepareSyntheticLinkDimensions(cube);
+    this.prepareMembers(cube.dimensions, cube, errorReporter);
     this.prepareMembers(cube.segments, cube, errorReporter);
 
     this.evaluateMultiStageReferences(cube.name, cube.measures);

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

@@ -712,29 +712,9 @@ export class CubeSymbols implements TranspilerSymbolResolver, CompilerInterface
           .map((path) => path.split('.')[1])
           .filter(memberName => !(it.includes as (string | ViewCubeIncludeMember)[]).find((include) => ((typeof include === 'object' ? include.name : include)) === memberName));
 
-        // Auto-include synthetic link dimensions for any included dimension that has links
-        const syntheticLinkMembers: string[] = [];
-        const membersObj = this.symbols[cubeRef]?.cubeObj()?.dimensions || {};
-        for (const include of (it.includes as (string | ViewCubeIncludeMember)[])) {
-          const memberName = typeof include === 'object' ? include.name : include;
-          const dimDef = membersObj[memberName];
-          if (dimDef && dimDef.links && Array.isArray(dimDef.links)) {
-            for (const link of dimDef.links) {
-              if (link.name) {
-                const syntheticName = `${memberName}___link_${link.name}_url`;
-                if (membersObj[syntheticName]) {
-                  syntheticLinkMembers.push(syntheticName);
-                }
-              }
-            }
-          }
-        }
-
         return {
           ...it,
-          includes: (it.includes as (string | ViewCubeIncludeMember)[])
-            .concat(currentCubeAutoIncludeMembers)
-            .concat(syntheticLinkMembers.filter(m => !(it.includes as (string | ViewCubeIncludeMember)[]).find((inc) => ((typeof inc === 'object' ? inc.name : inc)) === m))),
+          includes: (it.includes as (string | ViewCubeIncludeMember)[]).concat(currentCubeAutoIncludeMembers),
         };
       }) : includedCubes;
 
@@ -1024,6 +1004,7 @@ export class CubeSymbols implements TranspilerSymbolResolver, CompilerInterface
           ...(resolvedMember.multiStage && { multiStage: resolvedMember.multiStage }),
           ...(resolvedMember.keyReference && this.processKeyReferenceForView(resolvedMember.keyReference, targetCube.name, viewAllMembers, memberRef.member)),
           ...(resolvedMember.mask !== undefined ? { mask: resolvedMember.mask } : {}),
+          ...(resolvedMember.links ? { links: resolvedMember.links } : {}),
         };
       } else if (type === 'segments') {
         memberDefinition = {